Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Set manager_ref to file path for embedded ConfigurationScripts #711

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 14, 2023

The manager_ref is typically used to track the "unique" attribute of an object, for ansible_tower/awx the manager_ref is the job_template.id but for embedded_ansible the manager_ref was nil and the name was set to the file path.

Embedded Workflows copied this behavior, but it would be preferable to match how the "external" automation managers operate and also open up the :name column for a more user friendly name.

@agrare agrare changed the title [WIP] Set manager_ref to file path for embedded scripts [WIP] Set manager_ref to file path for embedded ConfigurationScripts Nov 14, 2023
@miq-bot miq-bot added the wip label Nov 14, 2023
The manager_ref is typically used to track the "unique" attribute of an
object, for ansible_tower/awx the manager_ref is the job_template.id but
for embedded_ansible the manager_ref was nil and the name was set to the
file path.  Embedded Workflows copied this behavior, but it would be
preferable to match how the "external" automation managers operate and
also open up the `:name` column for a more user friendly name.
@agrare agrare force-pushed the set_manager_ref_embedded_configuration_scripts branch from 5ee9c1d to 3e33249 Compare November 14, 2023 17:37
@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2023

Checked commit agrare@3e33249 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@miq-bot miq-bot added the stale label Feb 19, 2024
@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

2 similar comments
@miq-bot
Copy link
Member

miq-bot commented May 20, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Aug 26, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants