use shading enums to remove warnings #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is new as of 0.20! |
|
Ok thanks. Do you think its worth trying to support both 0.19 and 0.20 here, or just switching to 0.20? |
|
I've been in the force updating camp most of the time to optimize maintainer time ;) |
|
Me to but I get in trouble for it 😅 |
|
Haha in the end I also have to downgrade everything to 0.19 because MakieDraw is totally broken on 0.20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simon was this enum available in Makie 0.19 or should I fix the version to 0.20 ?