removed screen for running version with JSServe

[TabeaW]

With this Tyler works smoothly with JSServe (#47). The only problem might be the for-loops which are now true permanently.

[TabeaW]

using JSServe
using Tyler,Extents,WGLMakie
server=JSServe.Server("0.0.0.0", 8082)
extent=Extent(Y=(46.18,55.78),X=(3.088,17.112)) #Germany
tyler=Tyler.Map(extent)
route!(server, "/browser-display" => App(tyler.figure))

will show the tyler map in the JSServe App.

[rafaqz]

Thanks. Im mostly concerned that this change means we are spawning tasks that never break out of their while loops.

[rafaqz]

Does this mean the task runs forever now?

[TabeaW]

That's the big question, I am not quite sure about that, but had no real alternative without the screen in mind.

[rafaqz]

My guess is this task will just keep running every 0.01 seconds until you kill the session, unless it hits another error from the Makie screen not being there anymore (but I think it wont?).

We can't really do that... we need to find another way of breaking the loop.

[rafaqz]

Maybe try printing to stdout in the task and see what happens

[rafaqz]

Same here

[SimonDanisch]

I think I should add a function to makie a la waiting_isopen that waits until the scene/figure actually gets displayed and only then starts returning true/false! I think only with that we can have a clean condition for those loops

[SimonDanisch]

Implemented in #69