tweak tile load order #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just a minor test error. |
|
I'll need to work on the merge of new master into this, since my geomakie pr replicates some of the functions that this touches. Maybe we want to introduce some more API functions to avoid the duplication though. |
|
Ok @asinghvi17 its good from my side if you want to handle the merge |
asinghvi17
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks tile load order mostly following #115
There is a bit of cleanup of names with
current_tiles => foreground_tilesfor clarity, but the main change is addingoffscreentiles as separate frombackgroundtiles, and loading tiles background -> foreground -> offscreen.We usually want background tiles plotting first as they are low-resolution and can fill the view immediately. Foreground tiles load after that. Then offsecreen/halo tiles can load last after everything visible has loaded, to be ready for zooming and panning.
The other change is to make mouse-first loading work again, so the sweep of tile loading is less visible and the tile you want to look at loads first.