Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informative error if invalid side is used for violin #4612

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

jkrumbiegel
Copy link
Member

Before, an invalid symbol would just be treated as :both

@jkrumbiegel jkrumbiegel added the skip-changelog Skips changelog enforcer label Nov 21, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Nov 21, 2024

Benchmark Results

SHA: e2fe39b4b80aea63e00127cf393a1e9e3d73f4b1

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@jkrumbiegel jkrumbiegel merged commit 63ccff6 into master Nov 24, 2024
21 of 22 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/violin-error branch November 24, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants