Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2D assumption in point-based convert_args for lines #4585

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented Nov 11, 2024

Description

Fixes # (issue)

Allows plotting 3D polygons via lines and scatter, previously not possible because a Point2 was injected. This PR removes the 2D assumption, instead using a Point{N, float_type(T)}(NaN).

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 11, 2024

Benchmark Results

SHA: 8648a5d2fab49c35da98b127b9ff68d9772a15b7

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@asinghvi17
Copy link
Member Author

WGLMakie failures seem unrelated.

@SimonDanisch SimonDanisch merged commit 2feb058 into master Nov 12, 2024
21 of 22 checks passed
@SimonDanisch SimonDanisch deleted the as/lines_3d_polygon branch November 12, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants