add kwarg to rotate Toggle

[bjarthur]

Description

fixes #4378; supersedes #4445.

adds orientation kwarg to Toggle that specifies the angle in radians to rotate the toggle. default of 0 is horizontal with active being to the right.

Type of change

• New feature (non-breaking change which adds functionality)

Checklist

• Added an entry in CHANGELOG.md (for new features and breaking changes)
• Added or changed relevant sections in the documentation
• Added unit tests for new algorithms, conversion methods, etc.
• Added reference image tests for new plotting functions, recipes, visual options, etc.

[bjarthur]

[bjarthur]

i just noticed that the vertical alignment is off when rotated:

i would've thought the top edges of both toggles should be at the same height. can someone please suggest how i can fix this?

julia> using GLMakie

julia> fig = Figure()

julia> scatter(fig[1,1], [1,2,3], axis = (; height=200))
Makie.AxisPlot(Axis (1 plots), Scatter{Tuple{Vector{Point{2, Float64}}}})

julia> Toggle(fig[1,2], orientation=:vertical, valign=:top)
Toggle()

julia> Toggle(fig[1,3], orientation=:horizontal, valign=:top)
Toggle()

[bjarthur]

i've fixed the alignment issue in the previous comment by refactoring to do my own rotation instead of using @ffreyer 's method. i couldn't figure out another way to do it.

everything seems to work, and i suspect tests will pass, but only because none of the reference images uses the width or height kwargs to Toggle.

there is a slight backwards incompatibility that might warrant a bump in Makie's minor version with this PR as the size of the toggle is now controlled by length and markersize instead of width and height. with the new orientation kwarg i feel this is a much more natural parameterization. let me know if you disagree.

[bjarthur]

i'm confused about the CI failure for ref img "Button - Slider - Toggle - Textbox":

running 241: Button - Slider - Toggle - Textbox
Button - Slider - Toggle - Textbox: Error During Test at /home/runner/work/Makie.jl/Makie.jl/ReferenceTests/src/database.jl:51
  Test threw exception
  Expression: save_result(joinpath(RECORDING_DIR[], "Button - Slider - Toggle - Textbox"), result)
  No applicable_savers found for UNKNOWN

it works fine locally and nothing in this PR should effect that test.

[bjarthur]

could you please review again?

[ffreyer]

Tests fail because I merged the new refimg with an existing one. So no problem there.

I'm not sure about the (width, height) -> (length, markersize) change. I see why it's there but I wonder if width, height is supposed to be something users can always set. Right now it gets overwritten if I'm not mistaken.

[jkrumbiegel]

The boundingbox computation does not work correctly for all rotations yet which you can check like this:

f = Figure()
rot = Observable(0.0)
Box(f[1, 1], color = :tomato)
Toggle(f[1, 1], orientation = rot)
sl = Slider(f[1, 2], range = 0:0.01:2pi)
connect!(rot, sl.value)
f

[bjarthur]

oof. good catch. fixed in latest commit. i've added a ref image to test for this too.