Add zooming & translation controls to Axis3 #4131

ffreyer · 2024-08-14T12:50:09Z

Description

Now that #3958 has been merged we can implement zooming and translation for Axis3 without data spilling out of he Axis limits.

Old Description

I don't aim to work on this immediately. Instead I'm hoping that this pr can spark some discussions on how zooming and translations should work with Axis3, so that the end result is more polished.

Some questions:

What point should zooming relate to?
- The center?
- A point offset from the center based on the mouse position?
- A data point under the mouse?
Should up/down mouse movements strictly map to z-axis translations, and left/right mouse movements strictly map to xy-axis translations? Or should they freely map to the corresponding (x, y, z) vectors?
How should translation speed scale with zoom? Should we set a maximum based on data limits to avoid losing sight of data?
What things should we port from Camera3D/LScene? E.g.:
- Directional restrictions for translations when pressing x/y/z and translating
- Focus on clicked object/point on object (left alt + left click)
- Recenter hotkey (left ctrl + left click)
- Keyboard controls

I extended the following interactions to work with Axis3:

ScrollZoom which comes with x/y/zzoomlock and x/y/zzoomkey Axis3 attributes like Axis does, and additionally a zoommode which controls whether zoom is centered on the Axis3 area (default) or on the cursor (1)
DragPan which comes with x/y/ztranslationlock and x/y/ztranslationkey rather than ...pan... as pan technically refers to a rotation of the camera.
LimitReset

(1) "zoom centered on the cursor" really means that we want to keep a point under the cursor at the same location as we zoom in or out. With perspective projection in 3D this depends on the depth value of the point, which changes as we zoom. Without knowing exactly where that point is, we cannot fulfill that condition. And even if we ray-cast to find the coordinate, another point at a different depth that initially overlapped will move away as we zoom. Because of that I think it's better to just zoom towards the well-defined center.

TODO:

update documentation
~~maybe add interaction for "center on clicked object"~~
Reuse naming scheme and interactions from Axis
Add tests, check failures
fix axis reversal
fix CairoMakie text clipping
~~Discuss whether clipping related changes count as breaking or bug fixes~~ I think it doesn't actually change anything...?
test every possible viewmode with different perperspectiveness, axis reversals and aspect settings

Related issues: #3792, #1655, #1667

Type of change

New feature (non-breaking change which adds functionality)

Checklist

Added an entry in CHANGELOG.md (for new features and breaking changes)
Added or changed relevant sections in the documentation
Added unit tests for new algorithms, conversion methods, etc.
Added reference image tests for new plotting functions, recipes, visual options, etc.

MakieBot · 2024-08-14T13:05:54Z

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)

	using	create	display	create	display
GLMakie	4.47s (4.42, 4.53) 0.04+-	108.30ms (105.79, 112.15) 2.56+-	469.34ms (450.90, 490.37) 14.54+-	9.28ms (9.02, 9.58) 0.23+-	26.12ms (25.97, 26.31) 0.12+-
master	4.50s (4.46, 4.59) 0.04+-	108.03ms (104.61, 112.49) 3.05+-	475.31ms (468.93, 487.40) 6.21+-	9.52ms (9.18, 9.74) 0.18+-	26.28ms (25.98, 26.85) 0.29+-
evaluation	1.01x invariant, -0.03s (-0.72d, 0.21p, 0.04std)	1.00x invariant, 0.27ms (0.09d, 0.86p, 2.80std)	1.01x invariant, -5.96ms (-0.53d, 0.35p, 10.37std)	1.03x faster ✓, -0.24ms (-1.18d, 0.05p, 0.21std)	1.01x invariant, -0.16ms (-0.72d, 0.21p, 0.21std)
CairoMakie	4.23s (4.19, 4.28) 0.04+-	106.76ms (105.90, 108.51) 0.87+-	168.54ms (166.98, 171.73) 1.68+-	9.68ms (9.35, 9.79) 0.15+-	1.15ms (1.13, 1.17) 0.02+-
master	4.23s (4.17, 4.28) 0.04+-	107.60ms (105.59, 113.14) 2.52+-	167.65ms (166.43, 168.93) 0.93+-	9.72ms (9.35, 9.95) 0.19+-	1.16ms (1.14, 1.18) 0.02+-
evaluation	1.00x invariant, -0.0s (-0.04d, 0.95p, 0.04std)	1.01x invariant, -0.84ms (-0.45d, 0.43p, 1.69std)	0.99x invariant, 0.89ms (0.66d, 0.25p, 1.31std)	1.00x invariant, -0.04ms (-0.22d, 0.68p, 0.17std)	1.00x invariant, -0.0ms (-0.27d, 0.62p, 0.02std)
WGLMakie	4.68s (4.66, 4.70) 0.02+-	106.33ms (105.33, 108.51) 1.08+-	8.97s (8.89, 9.08) 0.07+-	11.36ms (11.17, 11.50) 0.15+-	117.89ms (113.84, 119.79) 2.04+-
master	4.71s (4.66, 4.83) 0.06+-	106.75ms (105.45, 109.86) 1.47+-	9.31s (9.22, 9.41) 0.08+-	11.66ms (11.30, 13.07) 0.63+-	117.50ms (114.12, 124.49) 3.25+-
evaluation	1.01x invariant, -0.03s (-0.71d, 0.23p, 0.04std)	1.00x invariant, -0.43ms (-0.33d, 0.55p, 1.28std)	1.04x faster ✓, -0.35s (-4.73d, 0.00p, 0.07std)	1.03x invariant, -0.3ms (-0.65d, 0.26p, 0.39std)	1.00x invariant, 0.39ms (0.14d, 0.79p, 2.65std)

asinghvi17 · 2024-08-14T14:12:14Z

Zooming for Axis3 is basically just shrinking finallimits, right?

ffreyer · 2024-08-14T15:49:47Z

I don't know yet. In the prototype code it is, but I don't know if that's a good way to do it. that code was really just to test if clip_planes allow me to cut off plots outside the Axis bbox while keeping the Axis decorations.

ffreyer · 2024-08-21T10:57:27Z

GLMakie/src/GLAbstraction/GLRender.jl

+    # TODO: This crashes? But is also necessary...
+    for i in max(0, N):7
+        glDisable(GL_CLIP_DISTANCE0 + UInt32(i))
+    end


Not sure in what context this was crashing but it's not crashing anymore on my laptop or PC.
Without this turning clip_planes on once will turn them on forever, with random data. This causes plots to disappear randomly. Maybe this should be a hotfix instead of being part of this pr...

ffreyer · 2024-11-23T22:44:13Z

I realized that I could also just reuse the viewmode != :free translation to allow you to center the plot. Now it's setup like this (with viewmode = :free):

right drag translates the content of the axis, allowing you to move the thing you want to rotate around and zoom towards into the center
ctrl + right draw translates the entire axis (in the window)
shift + left click now exists independently of ctrl + left click and re-centers content in the scene. ctrl - click reverts zooming, axis translations and rotations (maybe these tasks should be distributed differently?)
alt + click has been added to center what the cursor hovers

Also did a bit of cleanup and fixed a rendering bug caused by near being too small:

I also noticed that #3584 is reappearing here, because frame lines are projected manually

Which comes from just doing xyz/w in inversions. This is not valid if w <= 0, at least with perspective projection

ffreyer · 2024-11-25T14:07:44Z

I also noticed that #3584 is reappearing here, because frame lines are projected manually

I took the easy way out and just moved them to 3D space/scene. Technically this should also be an issue for ticks, tick labels and axis labels, but I think it's much more rare.

into ff/Axis3-controls

ffreyer · 2024-11-25T22:55:54Z

src/camera/projection_math.jl

@@ -390,7 +393,7 @@ function project(proj_view::Mat4{T1}, resolution::Vec2, point::Point{N, T2}) whe
    # at this point the visible range is strictly -1..1 so FLoat64 doesn't matter
    p = (clip ./ clip[4])[Vec(1, 2)]
    p = Vec2{T}(p[1], p[2])
-    return (0.5 .* (p .+ 1) .* (resolution .- 1)) .+ 1
+    return 0.5 .* (p .+ 1) .* resolution


Tick alignment with frame lines got worse when I moved the frame to data space. So I spent too long trying to figure out why.

I thought it might be a Float32 vs Float64 thing, so cleaned up the remaining Float32 types in Axis3. Didn't help. I tried forcing lines to convert on the CPU to make sure conversions don't happen till the end. Didn't help.

Then I got frustrated and moved the CairoMakie line point projection to Makie so I could revert moving the frame to data space without having clipping issues. And the alignment issues were still there. Then I tried using that code for ticks as well and it finally went away.

So i tried to figure out why and started comparing. Didn't notice the resolution - 1. Noticed that clip space points were very different, due to the CairoMakie code clipping to a -1..1 box. So I changed things up to avoid it and there was still a 0.5-1px difference. And then I finally noticed this line, changed it and I the issue seems to be fixed now.

Anyway, fixes #3302.

jkrumbiegel · 2024-11-26T14:51:41Z

I'm not sure if I like the translation feature because you cannot really control which axes get translated how much when dragging over a 2D plane. I guess I would put that one behind the ctrl key if at all

ffreyer · 2024-11-26T15:49:43Z

You mean the one that has also been added for viewmode != :free? You can restrict that with x, y, z to make it easier to control.

…h of labels/tick labels

ffreyer · 2024-11-29T00:54:30Z

The WGLMakie failure is just a refimg I forgot to update

* update CI * update versions * dont test on branch push (already runs for prs against master) * fix versions * Updates for GeometryBasics refactor (#4319) * get Makie to compile * get GLMakie to compile * fix nromal rename, meshscatter * fix pointtype in mesh conversion * avoid matrix in vector rotation * fix more tests * update GeometryBasics functions/interface * fix voronoiplot clipping * update CairoMakie * update RPRMakie * prepare WGLMakie * Update CI to use the GeometryBasics refactor branch (#4326) * Update ci.yml * Update Docs.yml * Update reference_tests.yml * add MeshIO branch --------- Co-authored-by: ffreyer <[email protected]> * update _faces * normals -> normal * add ShaderAbstractions to ci * update docs, normals deprecation * fix branch names * fix catmesh getting normals regenerated * update for ShaderAbstractions * handle voxel clipping in CairoMakie like in GLMakie * fix another two "normals" * add dev branches for RPRMakie CI * fix missing kwarg name in conversion * update for FaceViews * add example for per-face colors and normals * improve typing * fix Sampler, allow mipmap via Sampler * try to fix benchmarks * add to correct env * remove from master project * fix docs * fix Rect decomposition * fix poly converts * fix typo * improve precompilation by avoiding constprop and more direct icon loading via PNGFiles * fix CairoMakie precompile * fix old syntax * fix ambient light * add temp dependencies to relocatbility test * bump RPR to required version * update changelog * fix test * fix other branch in ray cast test * fix relocatability ci * fix rpr and relocatability --------- Co-authored-by: Anshul Singhvi <[email protected]> Co-authored-by: SimonDanisch <[email protected]> * rename clear_faceviews * update GeometryBasics dev branch * update CI * more CI bumps * fix relocatibility CI * fix 2x2 surface * fix CairoMakie * fix WGLMakie 2x2 surface * fix picking tests * remove reliance on Rect mesh generation * Metamesh and multi mesh loading (#4496) * prototype `mesh(::MetaMesh)` * tweak default color handling * add refimg test * add docs * add fallback for MetaMesh * update CI dependencies * try matching file without capitalization * fix CairoMakie, WGLMakie test errors * exclude from CairoMakie --------- Co-authored-by: ffreyer <[email protected]> * rename Tesselation -> Tessellation (#4564) * try fix benchmark * regenerate bundled * update Changelog [skip CI] * allow GeometryBasics 0.5 [skip ci] * Change automatic color generation for Voronoiplot (#4357) * Chane color generation * Changelog --------- Co-authored-by: Simon <[email protected]> Co-authored-by: Frederic Freyer <[email protected]> * add precompile for refreshcallback * try gc() between compile timings * update GeometryBasics, MeshIO versions * update ShaderAbstractions & CI * remove branches from relocatability * remove dev branches from docs * Split marker_offset from quad_offset (#4594) * split marker_offset from quad_offset * add test * fix typo * add 3D tests * fix FastPixel scaling with marker_offset in data space * improve test, remove old * fix CairoMakie image scatter offset * tweak test some more * test marker_offset with 2D and 3D rotations * fix 2D rotation + marker_offset + Rect in CairoMakie * exclude 3D test in CairoMakie * fix test error * 1.6 compat * update changelog * add attribute example * remove TODO * Add `transform_marker` attribute to meshscatter (#4606) * add transform_marker attribute * add refimg test * update changelog * allow mesh with no normals in mesh3d path * cleanup mesh3d transformation pipeline * add test * apply f32c.scale to meshscatter vertices in GLMakie, WGLMakie * fix WGLMakie * tweak test to include significant float32convert scaling * fix voxels * remove f32c + transform func tests (doesn't check what its supposed to) * fix wrong order for f32convert and model * fix double translation with transform_marker = true * fix unwanted model application with transform_marker = false * make limits static in test * test model + transform_marker with f32c and transform func * update and test boundingbox with transform_marker * Makie.rotate! * remove initial refimg test * update changelog * fix missing newline * fix deprecated normals * Add zooming & translation controls to Axis3 (#4131) * zoom prototype * add zooming as an Interaction * add limit reset * add translation * make translation more accurate * add docstrings * fix x/y/z reversed * update changelog [skip ci] * move code to the right places * fix corrupted gl state * fix CairoMakie text - clip planes interaction * remove comment * reuse and conform to existing infrastructure * add docs for Axis3 interactions * add unit tests & fix zoom coordinate system * do plot picking ray cast as part of :cursor zoom * remove old code * match zoom direction with Axis, LScene * update tests * add viewmode = :free * tweak refimg to include perspectiveness and be less wide * fix some test failures * revert change to decorations * fix backend dependency of new refimg * fix var name in new test * avoid rendering issues from too small near * skip irrelevant code for viewmode = :free * fix aspect problems with translations * cleanup some stuff * reuse in-axis translations for viewmode = :free * add center-on-cursor interaction * fix limit reset not resetting targetlimits * fix position_on_plot error for 2D meshes * move framelines to 3D scene to avoid line inversion issue Which comes from just doing xyz/w in inversions. This is not valid if w <= 0, at least with perspective projection * use Float64 * bandaid fix for render order * Change LimitReset to more closely match Axis * update docs * fix offset between ticks and grid/frame * fix test error * add test for project(scene, point) * add option to clip decorations (default on) * use viewport for clipping * don't clip decorations by default because it clips titles and too much of labels/tick labels * make test more robust --------- Co-authored-by: Simon <[email protected]> * Fix Float32 constraints in poly pipeline (#4615) * Fix Float32 constraints in poly pipeline Also fix dimensionality constraints * changelog * Update poly.jl * Update poly.jl --------- Co-authored-by: Simon <[email protected]> * try fixing memory leak * aggressively clean up objects * check screen outside animationframe + upload electron logs in CI * Clean up CI + CHangelog * Update CHANGELOG.md --------- Co-authored-by: Anshul Singhvi <[email protected]> Co-authored-by: SimonDanisch <[email protected]> Co-authored-by: Daniel VandenHeuvel <[email protected]>

* Added field fullbox to controll if the full box of Framelines is drawn. Added fields xspinecolor_4, yspinecolor_4 and zspinecolor_4 to control the color of the 4th line when the fullbox is drawn. * Renamed function to_topscene_z_2d into to_topscene_small_z_2d. Createted function to_topscene_big_z_2d to project points into parent space with a big z value * Renamed varaiable framepoints to framepoints_main. Added variable fraimpoints_fullbox replicating the functionality of assining to framepoints_main using p7 and p8 and the function to_topscene_big_z_2d. Added an if statement to add the front lines of the fullbox if the field fullbox od Axis3 is true. * Correctet/removed coments * Added spinecolor_4 to theme_black. * Create the fullbox lines anyway, just controll visibility by ax.fullbox && attr(:spinesvisible). * Changed the name "fullbox" into "front_spines" * spine_color * Update CHANGELOG.md * update CI * update versions * dont test on branch push (already runs for prs against master) * fix versions * Updates for GeometryBasics refactor (#4319) * get Makie to compile * get GLMakie to compile * fix nromal rename, meshscatter * fix pointtype in mesh conversion * avoid matrix in vector rotation * fix more tests * update GeometryBasics functions/interface * fix voronoiplot clipping * update CairoMakie * update RPRMakie * prepare WGLMakie * Update CI to use the GeometryBasics refactor branch (#4326) * Update ci.yml * Update Docs.yml * Update reference_tests.yml * add MeshIO branch --------- Co-authored-by: ffreyer <[email protected]> * update _faces * normals -> normal * add ShaderAbstractions to ci * update docs, normals deprecation * fix branch names * fix catmesh getting normals regenerated * update for ShaderAbstractions * handle voxel clipping in CairoMakie like in GLMakie * fix another two "normals" * add dev branches for RPRMakie CI * fix missing kwarg name in conversion * update for FaceViews * add example for per-face colors and normals * improve typing * fix Sampler, allow mipmap via Sampler * try to fix benchmarks * add to correct env * remove from master project * fix docs * fix Rect decomposition * fix poly converts * fix typo * improve precompilation by avoiding constprop and more direct icon loading via PNGFiles * fix CairoMakie precompile * fix old syntax * fix ambient light * add temp dependencies to relocatbility test * bump RPR to required version * update changelog * fix test * fix other branch in ray cast test * fix relocatability ci * fix rpr and relocatability --------- Co-authored-by: Anshul Singhvi <[email protected]> Co-authored-by: SimonDanisch <[email protected]> * rename clear_faceviews * update GeometryBasics dev branch * update CI * more CI bumps * fix relocatibility CI * fix 2x2 surface * fix CairoMakie * fix WGLMakie 2x2 surface * fix picking tests * remove reliance on Rect mesh generation * Metamesh and multi mesh loading (#4496) * prototype `mesh(::MetaMesh)` * tweak default color handling * add refimg test * add docs * add fallback for MetaMesh * update CI dependencies * try matching file without capitalization * fix CairoMakie, WGLMakie test errors * exclude from CairoMakie --------- Co-authored-by: ffreyer <[email protected]> * rename Tesselation -> Tessellation (#4564) * try fix benchmark * regenerate bundled * update Changelog [skip CI] * allow GeometryBasics 0.5 [skip ci] * Change automatic color generation for Voronoiplot (#4357) * Chane color generation * Changelog --------- Co-authored-by: Simon <[email protected]> Co-authored-by: Frederic Freyer <[email protected]> * add precompile for refreshcallback * try gc() between compile timings * update GeometryBasics, MeshIO versions * update ShaderAbstractions & CI * remove branches from relocatability * remove dev branches from docs * Split marker_offset from quad_offset (#4594) * split marker_offset from quad_offset * add test * fix typo * add 3D tests * fix FastPixel scaling with marker_offset in data space * improve test, remove old * fix CairoMakie image scatter offset * tweak test some more * test marker_offset with 2D and 3D rotations * fix 2D rotation + marker_offset + Rect in CairoMakie * exclude 3D test in CairoMakie * fix test error * 1.6 compat * update changelog * add attribute example * remove TODO * Add `transform_marker` attribute to meshscatter (#4606) * add transform_marker attribute * add refimg test * update changelog * allow mesh with no normals in mesh3d path * cleanup mesh3d transformation pipeline * add test * apply f32c.scale to meshscatter vertices in GLMakie, WGLMakie * fix WGLMakie * tweak test to include significant float32convert scaling * fix voxels * remove f32c + transform func tests (doesn't check what its supposed to) * fix wrong order for f32convert and model * fix double translation with transform_marker = true * fix unwanted model application with transform_marker = false * make limits static in test * test model + transform_marker with f32c and transform func * update and test boundingbox with transform_marker * Makie.rotate! * remove initial refimg test * update changelog * fix missing newline * fix deprecated normals * Add zooming & translation controls to Axis3 (#4131) * zoom prototype * add zooming as an Interaction * add limit reset * add translation * make translation more accurate * add docstrings * fix x/y/z reversed * update changelog [skip ci] * move code to the right places * fix corrupted gl state * fix CairoMakie text - clip planes interaction * remove comment * reuse and conform to existing infrastructure * add docs for Axis3 interactions * add unit tests & fix zoom coordinate system * do plot picking ray cast as part of :cursor zoom * remove old code * match zoom direction with Axis, LScene * update tests * add viewmode = :free * tweak refimg to include perspectiveness and be less wide * fix some test failures * revert change to decorations * fix backend dependency of new refimg * fix var name in new test * avoid rendering issues from too small near * skip irrelevant code for viewmode = :free * fix aspect problems with translations * cleanup some stuff * reuse in-axis translations for viewmode = :free * add center-on-cursor interaction * fix limit reset not resetting targetlimits * fix position_on_plot error for 2D meshes * move framelines to 3D scene to avoid line inversion issue Which comes from just doing xyz/w in inversions. This is not valid if w <= 0, at least with perspective projection * use Float64 * bandaid fix for render order * Change LimitReset to more closely match Axis * update docs * fix offset between ticks and grid/frame * fix test error * add test for project(scene, point) * add option to clip decorations (default on) * use viewport for clipping * don't clip decorations by default because it clips titles and too much of labels/tick labels * make test more robust --------- Co-authored-by: Simon <[email protected]> * Fix Float32 constraints in poly pipeline (#4615) * Fix Float32 constraints in poly pipeline Also fix dimensionality constraints * changelog * Update poly.jl * Update poly.jl --------- Co-authored-by: Simon <[email protected]> * try fixing memory leak * aggressively clean up objects * check screen outside animationframe + upload electron logs in CI * Clean up CI + CHangelog * Update CHANGELOG.md * fix merge, cleanup * add refimg test * add Sphere to verify z-order and check for artifacts * fiddle with rendering so that WGLMakie, CairoMakie order frame lines correctly without GLMakie, WGLMakie artifacting + tweak test --------- Co-authored-by: ffreyer <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: Anshul Singhvi <[email protected]> Co-authored-by: Daniel VandenHeuvel <[email protected]>

zoom prototype

385a2b0

ffreyer added 12 commits August 20, 2024 16:16

Merge branch 'master' into ff/Axis3-controls

00ed0e3

add zooming as an Interaction

7040ca7

add limit reset

61ab665

add translation

6df5852

make translation more accurate

b3db9d8

add docstrings

d5c125a

fix x/y/z reversed

199a9fc

update changelog [skip ci]

9eb6639

Merge branch 'master' into ff/Axis3-controls

9625654

move code to the right places

87aa380

fix corrupted gl state

2510151

fix CairoMakie text - clip planes interaction

0ae0409

ffreyer commented Aug 21, 2024

View reviewed changes

remove comment

f4553f3

ffreyer mentioned this pull request Aug 21, 2024

Fix clip state corruption #4157

Merged

5 tasks

ffreyer added 5 commits August 21, 2024 13:51

reuse and conform to existing infrastructure

f6eeafd

add docs for Axis3 interactions

b1083b9

add unit tests & fix zoom coordinate system

c95a439

do plot picking ray cast as part of :cursor zoom

c182e94

remove old code

12d8d5b

ffreyer marked this pull request as ready for review August 21, 2024 14:18

ffreyer requested a review from jkrumbiegel August 21, 2024 14:19

ffreyer added 2 commits August 21, 2024 19:49

match zoom direction with Axis, LScene

bb8835e

update tests

0abac18

This was referenced Aug 22, 2024

FR: Double click to go back to original zoom and orientation #827

Closed

Add ctrl-click to camera docs #1268

Closed

ffreyer added 4 commits November 23, 2024 23:10

reuse in-axis translations for viewmode = :free

77984cd

add center-on-cursor interaction

e283e96

fix limit reset not resetting targetlimits

e8888b3

fix position_on_plot error for 2D meshes

90762e3

move framelines to 3D scene to avoid line inversion issue

21815d4

Which comes from just doing xyz/w in inversions. This is not valid if w <= 0, at least with perspective projection

ffreyer changed the base branch from master to breaking-0.22 November 25, 2024 14:09

ffreyer added 9 commits November 25, 2024 15:10

Merge branch 'breaking-0.22' into ff/Axis3-controls

288ede8

use Float64

7f191d1

bandaid fix for render order

19f2dd7

Change LimitReset to more closely match Axis

77e48e8

update docs

0ebf94e

Merge branch 'ff/Axis3-controls' of https://github.com/MakieOrg/Makie.jl

3823a3f

into ff/Axis3-controls

fix offset between ticks and grid/frame

6c9a4f8

fix test error

fabf49e

add test for project(scene, point)

838d04d

ffreyer commented Nov 25, 2024

View reviewed changes

ffreyer added 2 commits November 26, 2024 15:14

add option to clip decorations (default on)

cfaabec

use viewport for clipping

2c698cf

ffreyer added 3 commits November 28, 2024 15:36

don't clip decorations by default because it clips titles and too muc…

79e78f1

…h of labels/tick labels

Merge branch 'breaking-0.22' into ff/Axis3-controls

49f5e2f

make test more robust

6bfdce2

ffreyer merged commit eca0f7f into breaking-0.22 Nov 29, 2024
20 of 22 checks passed

ffreyer deleted the ff/Axis3-controls branch November 29, 2024 00:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add zooming & translation controls to Axis3 #4131

Add zooming & translation controls to Axis3 #4131

ffreyer commented Aug 14, 2024 •

edited

Loading

MakieBot commented Aug 14, 2024 •

edited

Loading

asinghvi17 commented Aug 14, 2024

ffreyer commented Aug 14, 2024

ffreyer Aug 21, 2024

ffreyer commented Nov 23, 2024

ffreyer commented Nov 25, 2024

ffreyer Nov 25, 2024

jkrumbiegel commented Nov 26, 2024

ffreyer commented Nov 26, 2024

ffreyer commented Nov 29, 2024

Add zooming & translation controls to Axis3 #4131

Add zooming & translation controls to Axis3 #4131

Conversation

ffreyer commented Aug 14, 2024 • edited Loading

Description

Type of change

Checklist

MakieBot commented Aug 14, 2024 • edited Loading

Compile Times benchmark

asinghvi17 commented Aug 14, 2024

ffreyer commented Aug 14, 2024

ffreyer Aug 21, 2024

Choose a reason for hiding this comment

ffreyer commented Nov 23, 2024

ffreyer commented Nov 25, 2024

ffreyer Nov 25, 2024

Choose a reason for hiding this comment

jkrumbiegel commented Nov 26, 2024

ffreyer commented Nov 26, 2024

ffreyer commented Nov 29, 2024

ffreyer commented Aug 14, 2024 •

edited

Loading

MakieBot commented Aug 14, 2024 •

edited

Loading