Merge pull request #41 from JuliaPlots/sd/workless

only render on update
MakieOrg · May 19, 2020 · 1be05e2 · 1be05e2
2 parents 1e934fd + 5417787
commit 1be05e2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/Project.toml b/Project.toml
@@ -24,7 +24,7 @@ FileIO = "1.1"
 GeometryBasics = "0.2.3"
 Hyperscript = "0.0.3"
 ImageTransformations = "0.7, 0.8"
-JSServe = "0.6"
+JSServe = "0.6.6"
 MakieGallery = "0.2.1"
 MeshIO = "0.4"
 Observables = "0.3"

diff --git a/src/WGLMakie.jl b/src/WGLMakie.jl
@@ -170,10 +170,11 @@ function add_scene!(three, scene::Scene)
         }
         function render_all(){
             render_scene($(js_scene));
-            // Schedule the next frame.
-            requestAnimationFrame(render_all);
         }
-        requestAnimationFrame(render_all);
+        // render first frame
+        render_all();
+        // Render only when something updates!
+        on_update_observables_callbacks.push(render_all);
     """)
 end