Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forced variation example #4

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

ptessier
Copy link
Collaborator

@ptessier ptessier commented Jan 10, 2024

This change is Reviewable


  • Add example to update the user id
  • Add example to force a variation
  • Polish UI

Let me know if you see ways to make home page more readable.

https://us02web.zoom.us/clips/share/m65vnwnskfTq6wnoNnjcCRz02idKE-uQKBZ54Iy00wyYbYbZWbHAV5F6XsW0WRFNpDHozsNJffcvDWGqdgHJvM2X.uQ2yGVUwOKrbQjs3

Screenshot 2024-01-10 at 9 57 49 AM

@ptessier ptessier added the enhancement New feature or request label Jan 10, 2024
@ptessier ptessier requested review from mathieumg and a team January 10, 2024 14:58
@ptessier ptessier self-assigned this Jan 10, 2024
Copy link

@darwish darwish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @mathieumg and @ptessier)


packages/react/src/pages/home.tsx line 122 at r1 (raw file):

            placeholder="variation key"
            value={variationKey}
            onChange={(e) => setVariationKey(e.target.value)}

Q: If I set the variation key to "treatment" or "control" should it change the results of the experiment assignment?

@ptessier
Copy link
Collaborator Author

packages/react/src/pages/home.tsx line 122 at r1 (raw file):

Previously, darwish (Mike Darwish) wrote…

Q: If I set the variation key to "treatment" or "control" should it change the results of the experiment assignment?

It should change the assignment yes
At least, it should write that "reason: forced variation found"

Copy link

@darwish darwish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @mathieumg and @ptessier)


packages/react/src/pages/home.tsx line 122 at r1 (raw file):

Previously, ptessier (Philippe Tessier) wrote…

It should change the assignment yes
At least, it should write that "reason: forced variation found"

Doesn't seem to work for me (on a fresh repo clone at least)

Copy link

@darwish darwish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mathieumg and @ptessier)


packages/react/src/pages/home.tsx line 121 at r1 (raw file):

            type="input"
            placeholder="variation key"
            value={variationKey}

Nit (UX): it's a bit annoying that you have to retype the experiment and variation keys each time you want to play around with the forced variations.


packages/react/src/pages/home.tsx line 122 at r1 (raw file):

Previously, darwish (Mike Darwish) wrote…

Doesn't seem to work for me (on a fresh repo clone at least)

Nvm, wasn't built properly

Copy link

@kdziuba-mx kdziuba-mx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @darwish, @mathieumg, and @ptessier)


packages/react/src/pages/home.tsx line 121 at r1 (raw file):

Previously, darwish (Mike Darwish) wrote…

Nit (UX): it's a bit annoying that you have to retype the experiment and variation keys each time you want to play around with the forced variations.

+1

Copy link
Collaborator Author

@ptessier ptessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mathieumg)


packages/react/src/pages/home.tsx line 121 at r1 (raw file):

Previously, kdziuba-mx (Kostiantyn Dziuba) wrote…

+1

Yeah maybe I can just put a force control or force treatment button?

@ptessier ptessier force-pushed the ptessier/add-forced-variations branch from 1e29c13 to e6ae46b Compare January 10, 2024 18:05
@ptessier
Copy link
Collaborator Author

packages/react/src/pages/home.tsx line 121 at r1 (raw file):

Previously, ptessier (Philippe Tessier) wrote…

Yeah maybe I can just put a force control or force treatment button?

Screenshot 2024-01-10 at 1.07.08 PM.png

Copy link
Collaborator Author

@ptessier ptessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @darwish, @kdziuba-mx, and @mathieumg)

Copy link

@darwish darwish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kdziuba-mx and @mathieumg)

@ptessier ptessier merged commit 4dedadb into master Jan 10, 2024
3 checks passed
@ptessier ptessier deleted the ptessier/add-forced-variations branch January 10, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants