Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 'Additional property enabled is not allowed' when using gotenb… #52

Merged
merged 5 commits into from
Nov 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
branches:
- master

permissions:
contents: write
packages: write

jobs:
release:
permissions:
Expand Down Expand Up @@ -44,3 +48,19 @@ jobs:
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
with:
config: .cr.yaml

- name: Login to GitHub Container Registry
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Push Charts to GHCR
run: |
for pkg in .cr-release-packages/*; do
if [ -z "${pkg:-}" ]; then
break
fi
helm push "${pkg}" oci://ghcr.io/${GITHUB_REPOSITORY_OWNER}/helm-charts
done
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Run helm-tools
run: |
pushd charts/gotenberg
helm-tool lint
helm-tool lint -e values.linter.exceptions
helm-tool schema | jq . > generated-schema.json
CURRENT_SCHEMA=$(cat values.schema.json)
GENERATED_SCHEMA=$(cat generated-schema.json)
Expand Down
6 changes: 6 additions & 0 deletions charts/gotenberg/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.9.1

- Fixing 'Additional property enabled is not allowed' when using gotenberg in helm dependency (Thanks to Anthony | [@anthosz](https://github.com/anthosz))
- Bump `gotenberg` version `8.12.0` -> `8.14.1`.
- Publish the chart to OCI registry.

## 1.9.0

- Add ability to create and configure `networkPolicy` (Thanks to Anthony | [@anthosz](https://github.com/anthosz))
Expand Down
4 changes: 2 additions & 2 deletions charts/gotenberg/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "1.9.0"
version: "1.9.1"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "8.12.0"
appVersion: "8.14.1"

keywords:
- gotenberg
Expand Down
3 changes: 2 additions & 1 deletion charts/gotenberg/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Gotenberg

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/gotenberg)](https://artifacthub.io/packages/helm/maikumori/gotenberg)
![Version: 1.9.0](https://img.shields.io/badge/Version-1.9.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 8.12.0](https://img.shields.io/badge/AppVersion-8.12.0-informational?style=flat-square)
![Version: 1.9.1](https://img.shields.io/badge/Version-1.9.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 8.14.1](https://img.shields.io/badge/AppVersion-8.14.1-informational?style=flat-square)

This is a HELM chart for Gotenberg.

Expand Down Expand Up @@ -145,6 +145,7 @@ helm upgrade my-release maikumori/gotenberg --install
| serviceAccount.create | bool | `false` | Specifies whether a service account should be created |
| serviceAccount.name | string | `""` | The name of the service account to use. # If not set and create is true, a name is generated using the fullname template |
| strategy | object | `{}` | |
| testPodAnnotations | object | `{}` | Set annotations for the helm test pods (for example to disable certain kube-score checks) |
| tolerations | list | `[]` | |
| topologySpreadConstraints | list | `[]` | |
| volumeMounts | list | `[]` | |
Expand Down
1 change: 1 addition & 0 deletions charts/gotenberg/values.linter.exceptions
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
value missing from templates: enabled
8 changes: 8 additions & 0 deletions charts/gotenberg/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
"chromium": {
"$ref": "#/$defs/helm-values.chromium"
},
"enabled": {
"$ref": "#/$defs/helm-values.enabled"
},
"extraEnv": {
"$ref": "#/$defs/helm-values.extraEnv"
},
Expand Down Expand Up @@ -415,6 +418,11 @@
"type": "string",
"default": ""
},
"helm-values.enabled": {
"description": "-- Specifies that chart can be used as a condition when it is a dependency.\nSee https://helm.sh/docs/chart_best_practices/dependencies/#conditions-and-tags for more info.\n@ignored",
"type": "boolean",
"default": true
},
"helm-values.extraEnv": {
"description": "-- List of extra environment variables for gotenberg container",
"type": "array",
Expand Down
5 changes: 5 additions & 0 deletions charts/gotenberg/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

# -- Specifies that chart can be used as a condition when it is a dependency.
# See https://helm.sh/docs/chart_best_practices/dependencies/#conditions-and-tags for more info.
# @ignored
enabled: true

replicaCount: 1

image:
Expand Down