WIP: Fixes during setup of Bruker scanner #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the low level reconstruction method is somehow stuck between the old way of defining the regularization parameters and the new way causing the keyword parameters to not create the correct regularization terms.
@nHackel Maybe you could check if the way I changed the parameters is the intended way to use the enforceReal/Positive and lambda parameters in the new structure or if the regularization parameters should always be given as the reg vector.
I am not done with the setup of our scanner, so there might be more fixes down the line. I do not need to merge fast