Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix card multiverseid type so to work with the actual type from api #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix card multiverseid type so to work with the actual type from api #11

wants to merge 1 commit into from

Conversation

Ion-manden
Copy link

As the title says, the current type for card.MultiverseId is not correct, go sdk expect uint32 but the api response with a string.

@Ion-manden Ion-manden mentioned this pull request Dec 2, 2021
Open
@walanpat
Copy link

Contacting someone to see if I can get this PR approve/pushed through.

@Enviy
Copy link

Enviy commented Jan 15, 2023

Is there an update on this PR? Or does anyone know if there's someone who can land this change?

@gravestench
Copy link

BUMP

@Ion-manden
Copy link
Author

Sadly looks like all the repoes here are unmaintained now.

You should be able to just use my version by importing from "github.com/Ion-manden/mtg-sdk-go"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walanpat walanpat walanpat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ion-manden @walanpat @Enviy @gravestench