fix (bar helper). Set x coordinate to 0 if date grater than xDate - 1 is not found #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to provide a workaround fix for #192
It is a simple solution that works, but not a clean solution imo. Here the reason why:
If I am defining a react state that I pass as a prop to the Gantt to control the viewMode, and I never set this viewMode to null, there is no reason why the viewMode inside some of the Gantt functions should be null at some point, making the entire application crash or enter an infinite loop. It would be better to figure out why the viewMode is set to null at some cases (when switching fast between viewModes several times).
Sadly, I do not have more time to investigate it, so I leave the decision of accepting / rejecting this PR up to you