Fixed sounds off-by-1 (Issue #120).

MTrop · Nov 8, 2024 · 09d1d4a · 09d1d4a
1 parent 57b2a02
commit 09d1d4a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/net/mtrop/doom/tools/decohack/contexts/AbstractPatchContext.java b/src/main/java/net/mtrop/doom/tools/decohack/contexts/AbstractPatchContext.java
@@ -863,8 +863,7 @@ protected void writeCommonPatchBody(Writer writer) throws IOException
 				continue;
 			if (!sound.equals(original) || sound.hasCustomProperties())
 			{
-				// Sound ids in DeHackEd are off by 1
-				writer.append("Sound ").append(String.valueOf(i - 1)).append(CRLF);
+				writer.append("Sound ").append(String.valueOf(i)).append(CRLF);
 				sound.writeObject(writer, original, getSupportedFeatureLevel());
 				writer.append(CRLF);
 			}

diff --git a/src/main/resources/docs/changelogs/CHANGELOG-decohack.md b/src/main/resources/docs/changelogs/CHANGELOG-decohack.md
@@ -4,6 +4,7 @@ DECOHack
 ### Changed for 0.34.0
 
 * `Fixed` Any clause that sets intervals (freeing things, protecting states) may create a condition that causes an endless loop. (Issue. #119)
+* `Fixed` Sound entries were off by 1 due to a misunderstanding of what index sound entries started at. (Issue #120)
 
 
 ### Changed for 0.33.0