Signalements – Revoir le mode d'archivage des alertes "FAR 48h" #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louptheron
changed the title
…e_48_hours_missing_far_reportings.sql
louptheron
force-pushed
the
loup/refactor_48_alert_far_archive
branch
from
807fdf9
to
f78b859
Compare
ivangabriele
approved these changes
Oct 30, 2024
Comment on lines
39
to
40
| const isAlertUnarchivable = | ||
| reporting.type === ReportingType.ALERT && reporting.value.type === PendingAlertValueType.MISSING_FAR_48_HOURS_ALERT |
There was a problem hiding this comment.
Suggested change
| const isAlertUnarchivable = | |
| reporting.type === ReportingType.ALERT && reporting.value.type === PendingAlertValueType.MISSING_FAR_48_HOURS_ALERT | |
| const canBeArchived = | |
| !(reporting.type === ReportingType.ALERT && reporting.value.type === PendingAlertValueType.MISSING_FAR_48_HOURS_ALERT) |
? (taste)
| * we could have more middleware functions being called within the | ||
| * use-case middleware, and we should be able to capture all of these events. | ||
| */ | ||
| export const dispatchProcessor = (action, initialState) => { |
There was a problem hiding this comment.
Pouquoi ne pas suivre le nommage + doc officielle ?
There was a problem hiding this comment.
Tu pourrais me détailler ta proposition ? Tu veux dire faire un createSlice test ?
Note: Ici je ne veux pas descendre au niveau du fetch, pour ne pas avoir à gérer RTK.
|
|
En attente du passage des fichiers backoffice de JSX en TSX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
A exécuter en INTE/PROD :