Fixed bug with incorrect handling of unconfigured SSH agent

MOZGIII · Sep 26, 2016 · 0f5e8c1 · 0f5e8c1
1 parent cdee5e6
commit 0f5e8c1
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/ssh_config.go b/ssh_config.go
@@ -2,6 +2,7 @@ package dphx
 
 import (
 	"io/ioutil"
+	"log"
 	"net"
 	"os"
 
@@ -78,6 +79,11 @@ func (s SSHConfig) addAuthsForKeys(auths []ssh.AuthMethod) ([]ssh.AuthMethod, er
 }
 
 func (s SSHConfig) addSignersForAgent(signers []ssh.Signer) ([]ssh.Signer, error) {
+	if s.AgentAddr == "" {
+		log.Println("WARNING: SSH agent connection not configured, not using agent auth")
+		return signers, nil
+	}
+
 	sock, err := net.Dial("unix", s.AgentAddr)
 	if err != nil {
 		return nil, err