Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to download multiple files at once for published projects #1175 #1306

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Lucas-Mc
Copy link
Contributor

This change gives the user the option to download multiple files at once by using checkboxes next to the file name in the files panel. Currently, the user is required to manually go through each file and press the download button which is more tedious and, on my current setup, the files open when they are finished downloading which interrupts me trying to download multiple files at once. Further, the download button is far from the file name and sometimes it's difficult to tell if I'm downloading the correct file.

The user simply checks off which files they wish to download and then clicks the "Download Selected Items" button which automatically opens up the download URL for each of the selected files.

Fixes #1175.

@elfeto
Copy link
Collaborator

elfeto commented Mar 26, 2021

It would be helpful if there was a 'select all' option under the files section of a Physionet project.

It would still be helpful to have the "select all" if we are going to approve this PR since the issue it fix started with that statement.

@briangow
Copy link
Contributor

@Lucas-Mc this update is much welcomed! When clicking Download All Items it was only downloading the first file for me. Also, is it possible to allow downloading individual folders (and their included content)?

@Lucas-Mc
Copy link
Contributor Author

Lucas-Mc commented Apr 27, 2021

Hey @briangow, downloading individual folders and its nested contents may be much harder since an AJAX request happens in the background to load a folder's contents when it's clicked on so let's keep that as a feature request.

Also, as mentioned in our conversation offline, it appears like Chrome blocks multiple downloads at first due to security risks but after the user allows it for the hostname then it should work subsequently.

@briangow
Copy link
Contributor

Hey @Lucas-Mc , I'm able to download multiple files at once after giving site permissions to the Chrome pop-up blocker. Do you think we should put a note about allowing pop-ups somewhere (perhaps below the box that shows all the files)?

@Lucas-Mc
Copy link
Contributor Author

Nice! I think @tompollard should take a look first to see since he's better at judging the appearance of things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please provide a 'select all' option for files in a Physionet project
3 participants