Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft add client registry #32

Merged
merged 11 commits into from
Aug 5, 2024

Conversation

jabahum
Copy link
Contributor

@jabahum jabahum commented Jul 12, 2024

  • This PR adds client registry push and pulling of data

Copy link

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good besides a few cleanups, I am not sure how to test this visually

package.json Outdated Show resolved Hide resolved
src/client-registry/client-registry.component.tsx Outdated Show resolved Hide resolved
src/facility-registry/facility-registry.component.tsx Outdated Show resolved Hide resolved
src/product-registry/product-registry.component.tsx Outdated Show resolved Hide resolved
src/routes.json Outdated Show resolved Hide resolved
src/ui-components/overflow-menu.scss Show resolved Hide resolved
@jabahum jabahum marked this pull request as ready for review July 19, 2024 10:30
Copy link

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few things to clear


.arrowIcon {
fill: var(--cds-link-primary, #0f62fe) !important;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jabahum the new line issues seem to still be existing

@akileng56 akileng56 merged commit 54af125 into METS-Programme:main Aug 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants