Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/config_dict #28

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Feature/config_dict #28

merged 5 commits into from
Jul 29, 2024

Conversation

develop-cs
Copy link
Collaborator

@develop-cs develop-cs commented Jul 26, 2024

What?

Content :

Features

  • Add a new parameter config_dict in the RulesEngine's constructor. It can be used when you have already loaded the YAML configuration in a dictionary and want to use it straightforward.
  • Split a rule set in two (or more) files (keep the rules organized by their file names [alphabetically sorted]).

Fixes

  • Simple condition: an error occurs when the right operand is a uppercase string (e.g., input.text=="LABEL").

Refactoring

  • Function sanitize_regex() is converted to an instance method get_sanitized_id() of BaseCondition class.

Have you done?

  • Code tests
  • Update documentation
  • Update changelog

Details to be checked: (optional)

Many files are modified because of pre-commit hooks only.

Linked issues: (optional)

Signed-off-by: develop-cs <[email protected]>
Signed-off-by: develop-cs <[email protected]>
Copy link
Collaborator

@HugoPerrier HugoPerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top :)

@develop-cs develop-cs merged commit 3bcf4e6 into main Jul 29, 2024
4 checks passed
@develop-cs develop-cs deleted the feature/config_dict branch July 29, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to use a custom rule configuration loader
2 participants