scripts: Don't shallow copy pNext in command recording

This is a workaround for #102
LunarG · Sep 10, 2024 · aeb3c84 · aeb3c84
1 parent 9c79823
commit aeb3c84
Show file tree

Hide file tree

Showing 2 changed files with 71 additions and 68 deletions.
diff --git a/scripts/generators/command_recorder_generator.py b/scripts/generators/command_recorder_generator.py
@@ -137,7 +137,10 @@ def generateSource(self):
                     out.append(f'  for (uint32_t j = 0; j < {vkmember.fixedSizeArray[0]}; ++j) {{\n')
                     out.append(f'    ptr[i].{vkmember.name}[j] = {src_struct}.{vkmember.name}[j];\n')
                     out.append('  }\n')
-                elif vkmember.pointer and 'void' != vkmember.type and vkmember.name != 'pNext':
+                # https://github.com/LunarG/CrashDiagnosticLayer/issues/102 we need to deep copy the pNext chain here
+                elif vkmember.name == 'pNext':
+                    out.append(f'  ptr[i].{vkmember.name} = nullptr; // pNext deep copy not implemented\n')
+                elif vkmember.pointer and 'void' != vkmember.type:
                     out.append(f'    ptr[i].{vkmember.name} = nullptr;\n')
                     out.append(f'  if ({src_struct}.{vkmember.name}) {{\n')
                     if vkmember.length is not None and len(vkmember.length) > 0: