libs version update to support latest android studio #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parmeshtoyou I ran into this same issue yesterday and updated the tools in my local branch. @LukasLechnerDev It would be very helpful for future students to be able to clone the project and be up-and-running building the project. Would you be able to review this PR created by @parmeshtoyou? Thanks. |
...outineusecasesonandroid/usecases/coroutines/usecase1/PerformSingleNetworkRequestViewModel.kt
Outdated
Show resolved
Hide resolved
|
Thank you @parmeshtoyou for your contribution 💪 Could you please:
Then I think we can merge it! |
updated jdk version to 17
|
@LukasLechnerDev can we merge this PR? Provided comment addressed. |
LukasLechnerDev
merged commit fd7602e
into
LukasLechnerDev:coroutines_course_empty
1 check passed
|
Its merged! Thank you so much for your effort @parmeshtoyou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lukas,
After purchasing the course from udemy, i tried building your branch but it was not succeeded due to Android studio version update.
I have updated required libraries, gradle version and able to build the code on latest android version.
Android Studio Ladybug Feature Drop | 2024.2.2 Canary 4
Build #AI-242.23339.11.2422.12417746, built on September 26, 2024
Please review the changes and we can either keep these code in a new branch or update the existing one.
This will save other new devs time.
Thanks for this course.