VS Code Addon manager #76
Conversation
- Command waits for setup to finish
Refactor to use git submodules for addons
Also, crash a little nicer on startup if Git is not installed @carsakiller add wiki entry for new setting
|
GIF showing usage: |
|
Okay, I think the addon manager is good to go! I think there are just some smaller tasks to make sure everyone knows what is going on. Not sure if you want to wait for these to be done before releasing, up to you. I have written a little announcement post for when the addon manager goes live. It just briefly explains what it is and sort of how it works. This leaves a few things to address:
|
|
Unfortunately, I can't get it work |
|
🥴 yikes. I built, packaged it, and tested it on a completely fresh VM and things worked smoothly. Does it work at all? Highly possible I screwed up the setting for enabling it (by default)😆. If you can provide the log file, I can check it out in the morning ☕ |
|
It is a empty page and no output |
|
I found I didn't update the submodule |
|
Ah, are you not using the packaged |
No, I'm using Could you please provide a simple way to compile? |
|
Hm, that should work then. The actions should have compiled the TS and built webvue. You will want to run Alternatively you can run it in debug mode but it doesn't look accurate (especially the colours):
|
|
OK, it works! |
|
Nice! But why wasn't it built before 🤔 |
|
Because I runed |
|
But you installed the |
No, I always use the project it self. |
|
Ahhh, okay. I was confused because I thought you were using "Install from VSIX" to install the GH action artifact 🥴. A bit more detail can be found in the webvue repo. Glad it is working then! |
|
Maybe we need a script to compile client, including |
|
We could use |
Edited VS Code build task to use new client build script
|
@sumneko, what will be the new version number that has the addon manager and removes the built-in libraries? I am writing an announcement for the removal of the built-in libraries, but need to know which version it will be included in.
|
|
Also, I have somehow managed to activate discussions in vscode-lua, despite not having permission to disable it....
|
|
Hey @sumneko! Here is what I have for the announcement for the removal of the built-in libraries (to be posted ASAP): AnnouncementHello 👋 With the VS Code addon manager releasing very soon, we have decided to remove the built-in libraries that ship with the language server in the same release. This means the
Why?The addon manager for VS Code is releasing at the same time as this change, meaning everyone using the VS Code extension will still be able to install definition files super easily. Removing the built-in libraries helps prevent duplicates for those using VS Code and can help cut down on bloat for everyone. It is unlikely that everyone is interested in all the built-in libraries, so many of them end up not being used. What is the New Method?Libraries are now addons. The name “libraries” is a little misleading, as they are actually just definitions (and maybe a plugin). Those using VS Code can use the addon manager to install addons that contain all the definition files that were included in the language server, and more! Those using other clients can still download all the libraries that were included in the server from the LuaCATS organization. They can then be dropped into a folder and linked to with ContributeCollaboration on definition files is now better than ever. Do you have definition files for a library? Now is the time to contribute them! If you would like it to show up in the addon manager, you can add it to LLS-Addons. Do you have definition files that you can no longer maintain? If you transfer ownership to me (@carsakiller), I can transfer the project to LuaCATS, where the community can work together to keep the definitions up-to-date. And for the addon manager (to be posted at release of VS Code extension): AnnouncementNew in version X.XX of the VS Code extension is the addon manager! 🎉 It can be opened using Ctrl + P to open the command palette and searching for the SummaryThe addon manager allows you to enable, disable, and uninstall addons for the language server. This means you can now easily install definitions for libraries and automatically apply settings to better emulate an environment.
Contributing AddonsThe addon manager pulls from the LLS-Addons repository and currently contains many of the definitions from the language server. If you would like to contribute an addon, head over to the LLS-Addons README to learn more. They are very similar to the environment emulations that have been in use for a while, but add a little more configuration and are missing plugin support. WebVue UIThe addon manager is a webview (basically an iframe) that allows us to display a custom webpage within VS Code. You can check out the code for the webview UI in the vscode-lua-webvue repository. It uses Vue.js and some VS Code components and styling to try to make it feel as at-home as possible. FeedbackThe addon manager has been a while in the making, so I'm excited to finally merge it in. If you have any feedback, please leave it in the VS Code extension repository ❤️. I also have some wiki changes ready to go that deprecate the built-in libraries and explain addons (which replace the “environment emulations”) If you know the version that these changes will take place in, I can add it to the announcements. |
|
I can't guarantee the release cycle of the version, so I think it can be declared that it is removed in a medium version update after half a year. |
|
Okay, makes sense. Do you know which version the addon manager would be released in? |
|
It is not a break change for user, so I can publish a small version for it |
Adds an addon manager to VS Code that allows users to install addons from LLS-Addons.
Requires Git to be installed.