Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon manager plugin support #112

Open
carsakiller opened this issue Jan 14, 2023 · 0 comments
Open

Addon manager plugin support #112

carsakiller opened this issue Jan 14, 2023 · 0 comments
Labels
addon manager Related to the addon manager enhancement New feature or request

Comments

@carsakiller
Copy link
Collaborator

Explain the feature

The Lua Language Server supports plugins that allow users to write custom Lua scripts that the language server will then run to output a modified file. As of right now, the addon manager will download the plugin.lua file, but it will not tell the server to use it. There should be some easy (and safe) way for users to enable a plugin that they have installed.

Are there any potential drawbacks from adding the feature?

There are some serious security concerns with downloading a script off the internet and running it automatically on the user's computer. While the addons being installed should be reviewed and trusted before being merged into LLS-addons, there is always the chance of something slipping through.

We could ask the user to review the code themselves before approving the request to enable it - but at the end of the day, the safest option will always be to not run code created by other users.

@carsakiller carsakiller added the enhancement New feature or request label Jan 14, 2023
@carsakiller carsakiller transferred this issue from LuaLS/vscode-lua-webvue Mar 10, 2023
@carsakiller carsakiller added the addon manager Related to the addon manager label Mar 10, 2023
@carsakiller carsakiller changed the title Add support for plugins? Addon manager plugin support Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon manager Related to the addon manager enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant