Hotfix smbx2-lunalua plugin #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, nevermind about the plugin being set. I found my answer. Yeah it makes a lot of sense you don't want arbitrary code execution. (Though if we have to submit a PR to add that code it stands to reason that keeping it clean is enforceable) |
|
The original plan was to have the user review the plugin themselves before activating the plugin, but I never got around to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error with the plugin resolving modules which should now be resolved. Apologies for having to make a second pull request just to fix it. Currently I've got a branch of lua-language-server to add a setting which will deprecate this feature of the plugin so I'll make another PR to remove it if that gets approved.
Also, @carsakiller can you explain how the plugin is supposed to be added through the addon manager? When I tried enabling it, though it had the tag that said "Has Plugin" and the workspace.library was set, the plugin path in the settings.json was not set, and the plugin was not enabled. I had to manually set it. It seems to be this way for other addons with plugins too.