-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommendation Bolus Breakdown #2148
Open
motinis
wants to merge
55
commits into
LoopKit:dev
Choose a base branch
from
motinis:bolus-breakdown-cob
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 3.2
Merge dev into main for 3.2.1 release.
Backport cyclic dependency fixes from dev for building on Xcode 15
Fixup breakdown logic and add support for max bolus in breakdown
Sync to dev 3.5.0
* Cache profile expiration date in app and remove hardcoded provisioning profile path * Bump version to 3.4.2 for Xcode 16 patch --------- Co-authored-by: Jonas Björkert <[email protected]>
) * Adjust provisioning profile path in script for Xcode 16 compatibility * Bump version to 3.4.4 --------- Co-authored-by: Jonas Björkert <[email protected]>
Avoid calculating BG correction for ABC as it's not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a breakdown of the recommendation bolus to Carbs, COB and BG Corrections, to enable users to better decide how much bolus to manually give. For the case when Loop predicts one would go below the suspend threshold it includes an entry for Glucose Safety Limit which can be manually unchecked in order to give the insulin that Loop would have recommended when ignoring the suspend threshold.
See this discussion in zulipchat
The available entries to be displayed can be seen in this image
Update: Auto-Bolus Carbs (ABC) Experiment was added. When Enabled and Active, each Loop cycle, Loop will correct COB fully (but no positive BG corrections will be made) if this is greater than the usual automatic recommendation (note: to simplify the calculation for temp basal a surrogate auto-bolus recommendation is used for PBAF representing giving 1/6th of the dose when comparing). Link to screenshots for ABC