add IHttpClientFactory, GetCompletionAsync

Lokad · Apr 29, 2023 · 8cd945a · 8cd945a
1 parent 411a40c
commit 8cd945a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/src/Lokad.Prompting/ICompletionClient.cs b/src/Lokad.Prompting/ICompletionClient.cs
@@ -7,4 +7,5 @@ public interface ICompletionClient
     int GetTokenCount(string content);
 
     string GetCompletion(string prompt);
+    Task<string> GetCompletionAsync(string prompt);
 }
diff --git a/src/Lokad.Prompting/OpenAIClient.cs b/src/Lokad.Prompting/OpenAIClient.cs
@@ -18,9 +18,12 @@ public class OpenAIClient : ICompletionClient
 
     readonly GptEncoding _encoding;
 
-    public OpenAIClient(string apiKey, Model? model = null, double temperature = 0.0)
+    readonly int _maxTokens = 2049;
+
+    public OpenAIClient(string apiKey, Model? model = null, double temperature = 0.0, IHttpClientFactory httpClientFactory = null)
     {
         _api = new OpenAIAPI(apiKey);
+        _api.HttpClientFactory = httpClientFactory; // HINT: allow creating custom HttpClient (can be used to increase default Timeout)
         _model = model ?? Model.DavinciText;
         _temperature = temperature;
         _encoding = GptEncoding.GetEncoding("cl100k_base");
@@ -33,11 +36,24 @@ public int GetTokenCount(string content)
 
     public string GetCompletion(string prompt)
     {
-        return _api.Completions            
+        return _api.Completions
             .CreateCompletionAsync(
             new CompletionRequest(prompt,
                 model: _model,
                 temperature: _temperature,
-                max_tokens: 2049 /* HACK: this should not be hard-coded */)).Result.ToString();
+                max_tokens: _maxTokens
+                )).GetAwaiter().GetResult().ToString(); // HINT: we use GetAwaiter().GetResult() to avoid async/await also better than .Result
+    }
+
+    public async Task<string> GetCompletionAsync(string prompt)
+    {
+        var completionResult = await _api.Completions
+                        .CreateCompletionAsync(
+                            new CompletionRequest(prompt,
+                            model: _model,
+                            temperature: _temperature,
+                            max_tokens: _maxTokens
+                            ));
+        return completionResult.ToString();
     }
 }