-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check if homebrew exists #961
Conversation
Also @joaothallis is there a way to evaluate the |
You can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let us know if you're still interested on working on this PR
Hey @Enzime, definitely interested in submitting the PR. I've commited the suggessions and resolved the conflicts. Please do tell if I need to make any more changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash all the commits into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To squash the commits on this PR, the easiest solution would be while rebasing them on top of the latest master
First you need to make sure you have this repo as a remote:
$ git remote -v
upstream https://github.com/LnL7/nix-darwin.git (fetch)
upstream https://github.com/LnL7/nix-darwin.git (push)
The name can be anything, and if it’s not there you can use git remote add upstream https://github.com/LnL7/nix-darwin.git
$ git fetch
$ git checkout homebrewcheck
$ git rebase -i upstream/master
And in the rebase editor you can change all the pick
commands except the first to squash
Co-Authored-By: Michael Hoang <[email protected]>
ae1f27e
to
67fbc7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution
fixes #778
checkHomebrewInstall
should be a conditional checkcc: @Enzime please recommend changes