Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check if homebrew exists #961

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

codingCoffee
Copy link
Contributor

@codingCoffee codingCoffee commented Jun 1, 2024

fixes #778

  • unsure if checkHomebrewInstall should be a conditional check

cc: @Enzime please recommend changes

@codingCoffee codingCoffee marked this pull request as ready for review June 1, 2024 19:25
@codingCoffee
Copy link
Contributor Author

Also @joaothallis is there a way to evaluate the checkHomebrewInstall check only if the user has homebrew.enable = true in this nix configuration?

@emilazy
Copy link
Collaborator

emilazy commented Jun 13, 2024

You can use mkIf in the system.checks.text entry.

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let us know if you're still interested on working on this PR

modules/system/checks.nix Outdated Show resolved Hide resolved
modules/system/checks.nix Outdated Show resolved Hide resolved
@codingCoffee
Copy link
Contributor Author

Hey @Enzime, definitely interested in submitting the PR. I've commited the suggessions and resolved the conflicts. Please do tell if I need to make any more changes.

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash all the commits into one?

modules/system/checks.nix Outdated Show resolved Hide resolved
@codingCoffee
Copy link
Contributor Author

Hey @Enzime, I just ended up creating a separate PR: #1160. Squashing was proving to be difficult since this is such an old PR. If it's okay can you close this and merge the other one?

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To squash the commits on this PR, the easiest solution would be while rebasing them on top of the latest master

First you need to make sure you have this repo as a remote:

$ git remote -v
upstream  https://github.com/LnL7/nix-darwin.git (fetch)
upstream  https://github.com/LnL7/nix-darwin.git (push)

The name can be anything, and if it’s not there you can use git remote add upstream https://github.com/LnL7/nix-darwin.git

$ git fetch
$ git checkout homebrewcheck
$ git rebase -i upstream/master

And in the rebase editor you can change all the pick commands except the first to squash

modules/system/checks.nix Outdated Show resolved Hide resolved
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

homebrew.enable fails silently when homebrew is not installed
4 participants