Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults: add EnableTiledWindowMargins option #1166

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Beta-Computer
Copy link

add EnableTiledWindowMargins to WindowManager.nix to enable the ability to control margins with defaults

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the tests?

modules/system/defaults/WindowManager.nix Outdated Show resolved Hide resolved
modules/system/defaults/WindowManager.nix Outdated Show resolved Hide resolved
@Enzime
Copy link
Collaborator

Enzime commented Nov 15, 2024

Can you also squash the commits and change the commit message to defaults: add EnableTiledWindowMargins option?

@Beta-Computer Beta-Computer changed the title Add EnableTiledWindowMargins to WindowManager.nix defaults: add EnableTiledWindowMargins option Nov 15, 2024
@Beta-Computer
Copy link
Author

Can you update the tests?

tests updated but some fail and some pass

@@ -568,4 +572,4 @@ defaults write ~/Library/Preferences/ByHost/com.apple.controlcenter 'Sound' $'<?
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<integer>24</integer>
</plist>'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you change on this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think I changed anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants