-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: add rosetta2-gc #1165
base: master
Are you sure you want to change the base?
module: add rosetta2-gc #1165
Conversation
1d45654
to
868b752
Compare
We currently don't use it although eventually it would be great to just have it on by default for all the launchd daemons and agents we manage and then we can just turn on logging by default for them all |
868b752
to
378e9ce
Compare
2173c13
to
6092079
Compare
Provides a service to prune the Rosetta 2 JIT bytecode cache.
6092079
to
9e49401
Compare
Can you also add a test? |
Hmm, so what this service is actually doing is deleting all purgeable space from the disk, which AIUI is essentially cache data that is marked as inessential. It would I guess just purge the Rosetta 2 caches if the path to wherever those are is specified, but currently this has nothing to do with Rosetta 2 per se. Nominally, it’s fine to do this indiscriminately, because it’s the FS equivalent of flushing disk cache from memory. But it makes me wonder why this service was added to the infra and if there is some known problem it addresses? As with disk cache, this space is meant to be removed and reused automatically if anything else on the system needs the space, and as every Linux user knows it’s not actually a good thing if |
I don't know what the source for the command we're using is. But this one does it similarly and links to a source which is unfortunately down. The commit it was added in doesn't speak to the reason it was added. But with the throughput a nixos builder has I think it's reasonable to assume this fills up. As you can see in the log in the op it removes ~3 GB every two hours. Now it is of course hard to say if that is the same 3 GB it recreates in the next 3 hours. |
Provides a service to prune the Rosetta 2 JIT bytecode cache.
We have only ever used
minsize 0
as a criterion over in nixos/infra, so that it prunes indiscriminately.The logs look like this:
Does darwin have any log rotation service I could configure?