Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-daemon: enable by default #1164

Merged
merged 8 commits into from
Nov 16, 2024
Merged

nix-daemon: enable by default #1164

merged 8 commits into from
Nov 16, 2024

Conversation

Enzime
Copy link
Collaborator

@Enzime Enzime commented Nov 11, 2024

Single user installs have been unsupported by the official Nix installer since 2.4.

@Enzime Enzime force-pushed the push-yyusnrnkwkxu branch 2 times, most recently from 812b7f2 to 29f6a5f Compare November 11, 2024 11:56
@Enzime Enzime force-pushed the push-yyusnrnkwkxu branch 2 times, most recently from 0bcd2c4 to 8bbd8cd Compare November 11, 2024 12:48
Copy link
Collaborator

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single user installs have been unsupported by the official Nix installer since 2.4.

I don’t think that’s true, is it? I did a new single‐user installation of 2.24 in a VM recently. Rather it’s that they don’t work (at least, with SIP enabled) on Catalina or newer. I think it’s okay to drop support for older macOS versions but we should add a sw_vers check if so; it’s not really about the Nix version.

That said, this just changes defaults without actually dropping support for anything so I think it’s probably fine.

README.md Outdated Show resolved Hide resolved
@Enzime Enzime force-pushed the push-yyusnrnkwkxu branch 2 times, most recently from fce3dd6 to d00737c Compare November 11, 2024 22:21
@Enzime
Copy link
Collaborator Author

Enzime commented Nov 11, 2024

I believe they were disabled in NixOS/nix#4289

disable single-user installs on macOS

I assume a dedicated enough user could do a single-user install on macOS (probably do a multi-user install, delete the users and group and chown /nix)

Single user installs have been unsupported by the official Nix installer
since 2.4.
Remove suggestion to set `nix.useDaemon` as it came without an
explanation of how the `nix-daemon` would be unmanaged and would most
likely lead to most users running an old version of Nix as the daemon.
Copy link
Collaborator

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I used the official installer and I think I only had to pass --no-daemon. LGTM other than nit.

modules/examples/flake/flake.nix Outdated Show resolved Hide resolved
For Nix 1, some environment variables were set when using distributed
builds requiring the Nix daemon to be managed by nix-darwin. However,
support for Nix 1 has been removed and no other environment variables
for Nix are set by default.
@Enzime
Copy link
Collaborator Author

Enzime commented Nov 16, 2024

The PR above added these lines https://github.com/NixOS/nix/blob/master/scripts/install-nix-from-closure.sh#L61-L65 which disabled the --no-daemon flag

@emilazy
Copy link
Collaborator

emilazy commented Nov 16, 2024

Oh, hmm. I guess I did a daemon install but without a separate volume, then.

@Enzime Enzime merged commit 2bcef10 into LnL7:master Nov 16, 2024
6 checks passed
@Enzime Enzime deleted the push-yyusnrnkwkxu branch November 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants