Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(display): fix logic to remember ddprobe already ran #3293

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Oct 12, 2024

Description

This fixes a display capture initialization performance regression from #3002 that was reported in moonlight-stream/moonlight-common-c#93 (comment). The lines to set set_gpu_preference were accidentally refactored away. This caused ddprobe.exe to run every time that display capture initialized rather than just once.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@cgutman cgutman changed the title fix(windows): fix logic to remember ddprobe already ran fix(display): fix logic to remember ddprobe already ran Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 9.74%. Comparing base (7dd836d) to head (0b3dc59).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/platform/windows/display_base.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3293      +/-   ##
=========================================
- Coverage    9.75%   9.74%   -0.01%     
=========================================
  Files         101     101              
  Lines       17977   17981       +4     
  Branches     8420    8420              
=========================================
- Hits         1753    1752       -1     
- Misses      13330   15412    +2082     
+ Partials     2894     817    -2077     
Flag Coverage Δ
Linux 7.27% <ø> (ø)
Windows 5.09% <0.00%> (-0.01%) ⬇️
macOS-13 10.57% <ø> (ø)
macOS-14 10.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/display_base.cpp 13.49% <0.00%> (-0.11%) ⬇️

... and 33 files with indirect coverage changes

Copy link

sonarcloud bot commented Oct 12, 2024

@cgutman cgutman merged commit 5b435fd into LizardByte:master Oct 13, 2024
34 of 36 checks passed
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants