Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the RightSideRouterLinks problem + slight refactor #79

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix the RightSideRouterLinks problem + slight refactor #79

merged 2 commits into from
May 22, 2024

Conversation

speedyman08
Copy link
Contributor

@speedyman08 speedyman08 commented May 22, 2024 •
edited
Loading

This pull request:

Summary of changes:

  • To guarantee that this.login's viewChild is defined before the this.handleUserUpdate method is called, i made
    AppComponent implement the AfterViewInit hook

  • The GetInstanceInformation and theme stuff were moved to the AfterViewInit hook

  • the rightSideRouterLink .push method calls were moved to a separate method

@jvyden jvyden self-requested a review May 22, 2024 20:29
jvyden
jvyden reviewed May 22, 2024
View reviewed changes
Copy link
Member

@jvyden jvyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK at a glance, but I don't see the reason for moving theming stuff to AfterViewInit.

src/app/app.component.ts Outdated Show resolved Hide resolved
@speedyman08 speedyman08 requested a review from jvyden May 22, 2024 21:09
@jvyden jvyden merged commit 102e761 into LittleBigRefresh:master May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvyden jvyden jvyden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rightSideRouterLinks is an empty array on user update
2 participants
@speedyman08 @jvyden