Skip to content

Commit

Permalink
Update CI to Node 18, 20, and 21
Browse files Browse the repository at this point in the history
* test: support Node.js 20 JSON errors

Signed-off-by: Wouter Termont <[email protected]>

* build: bump node versions in manifest and ci workflow

Signed-off-by: Wouter Termont <[email protected]>

---------

Signed-off-by: Wouter Termont <[email protected]>
Signed-off-by: Wouter Termont <[email protected]>
Co-authored-by: Wouter Termont <[email protected]>
  • Loading branch information
termontwouter and woutermont authored Nov 24, 2023
1 parent b15d640 commit 339930d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
key: ${{ runner.os }}-lint-modules-${{ hashFiles('**/yarn.lock') }}
- uses: actions/setup-node@v2
with:
node-version: 14.x
node-version: 20.x
- run: yarn install
- run: yarn run lint

Expand All @@ -24,6 +24,9 @@ jobs:
node-version:
- 14.x
- 16.x
- 18.x
- 20.x
- 21.x
steps:
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"author": "Ruben Taelman <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=8.0"
"node": ">=14"
},
"scripts": {
"test": "npm run test:jest && npm run test:webpack",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2730,7 +2730,9 @@ describe('ParameterPropertyHandlerRange', () => {
.toEqual({
match: true,
value: {
description: `JSON parse exception: Unexpected token a in JSON at position 1`,
description: expect.stringMatching(
/JSON parse exception: (Unexpected token a|Expected property name or '\}') in JSON at position 1/u,
),
context: errorContext,
},
});
Expand Down

0 comments on commit 339930d

Please sign in to comment.