This repository has been archived by the owner on Oct 30, 2020. It is now read-only.
Merge json refactor #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…release branch. Part of pull request LinkedInAttic#49. Conflicts: docs/pom.xml perf/pom.xml pom.xml sensei-core/pom.xml sensei-gateways/pom.xml sensei-hadoop-indexing/pom.xml sensei-parent/pom.xml sensei-war/pom.xml
Previously, the dependency was satisfied by Zoie, but since we're deriving lucene classes in this project, it should be stated explicitly as a dependency.
- Use MetricFactory instead of Metrics to avoid using static MetricRegistry, which can't be reused once stopped - Avoid using static fields for all types of Metric.
Looks like the init() method is not always triggered. Move the metrics creation back into constructor first. This reverts commit 475b930.
Allow metrics related threads and mbeans cleanup on sensei server shutdown
…n to be max version Conflicts: sensei-core/src/main/java/com/senseidb/indexing/DefaultStreamingIndexingManager.java
Add the default Sensei UncaughtExceptionHandler Conflicts: sensei-core/pom.xml sensei-core/src/main/java/com/senseidb/conf/SenseiServerBuilder.java sensei-gateways/pom.xml
Conflicts: docs/pom.xml perf/pom.xml
…_array Conflicts: sensei-core/pom.xml
Lazy big int array
Looks ok. Merging in.
reformatting files - no code change
Conflicts: sensei-core/pom.xml sensei-federated-broker/pom.xml
Conflicts: clients/java/pom.xml sensei-core/pom.xml sensei-core/src/main/java/com/senseidb/conf/SenseiFacetHandlerBuilder.java sensei-core/src/main/java/com/senseidb/conf/SenseiServerBuilder.java sensei-core/src/main/java/com/senseidb/indexing/DefaultJsonSchemaInterpreter.java sensei-core/src/main/java/com/senseidb/indexing/DefaultStreamingIndexingManager.java sensei-core/src/main/java/com/senseidb/indexing/activity/CompositeActivityManager.java sensei-core/src/main/java/com/senseidb/indexing/activity/CompositeActivityValues.java sensei-core/src/main/java/com/senseidb/svc/impl/AbstractSenseiCoreService.java sensei-core/src/main/java/com/senseidb/svc/impl/CoreSenseiServiceImpl.java sensei-core/src/main/java/com/senseidb/util/SenseiUncaughtExceptionHandler.java sensei-core/src/test/java/com/senseidb/indexing/activity/PurgeUnusedActivitiesJobTest.java sensei-federated-broker/pom.xml
|
Is there any chance that this pull request would be merged? It has been a while since it was submitted. Without merging this pull request we can not bring other performance/stability Sensei fixes into this repo. Moreover as far I remember Josh spent lots of time preparing it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large pull request. It contains 3 things: