replace .intValue() to .intValueExact() and Math.toIntValueExact() fo…

…r all BigIntegers and Longs
LimeChain · Jan 15, 2025 · 9661198 · 9661198
1 parent 25c7b93
commit 9661198
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 11 deletions.
diff --git a/src/main/java/com/limechain/babe/Authorship.java b/src/main/java/com/limechain/babe/Authorship.java
@@ -194,7 +194,7 @@ public static Integer getSecondarySlotAuthor(byte[] randomness,
         var authorityIndex = rand.mod(authoritiesCount);
 
         if (authorityIndex.compareTo(authoritiesCount) < 0) {
-            return authorityIndex.intValue();
+            return authorityIndex.intValueExact();
         }
 
         return null;

diff --git a/src/main/java/com/limechain/network/protocol/blockannounce/scale/BlockHeaderScaleWriter.java b/src/main/java/com/limechain/network/protocol/blockannounce/scale/BlockHeaderScaleWriter.java
@@ -37,7 +37,7 @@ private void write(ScaleCodecWriter writer, BlockHeader blockHeader, boolean sea
         writer.writeUint256(blockHeader.getParentHash().getBytes());
         // NOTE: Usage of BlockNumberWriter is intentionally omitted here,
         //  since we want this to be a compact int, not a var size int
-        writer.writeCompact(blockHeader.getBlockNumber().intValue());
+        writer.writeCompact(blockHeader.getBlockNumber().intValueExact());
         writer.writeUint256(blockHeader.getStateRoot().getBytes());
         writer.writeUint256(blockHeader.getExtrinsicsRoot().getBytes());
 

diff --git a/src/main/java/com/limechain/network/protocol/warp/scale/writer/VarUint64Writer.java b/src/main/java/com/limechain/network/protocol/warp/scale/writer/VarUint64Writer.java
@@ -22,9 +22,9 @@ public void write(ScaleCodecWriter wrt, BigInteger value) throws IOException {
             throw new IllegalArgumentException("Negative values are not supported: " + value);
         }
         if (blockNumSize > 0) {
-            wrt.directWrite(value.and(BigInteger.valueOf(255L)).intValue());
+            wrt.directWrite(value.and(BigInteger.valueOf(255L)).intValueExact());
             for (int i = 1; i < blockNumSize; i++) {
-                wrt.directWrite(value.shiftRight(8 * i).and(BigInteger.valueOf(255L)).intValue());
+                wrt.directWrite(value.shiftRight(8 * i).and(BigInteger.valueOf(255L)).intValueExact());
             }
         }
     }

diff --git a/src/main/java/com/limechain/storage/block/BlockState.java b/src/main/java/com/limechain/storage/block/BlockState.java
@@ -582,9 +582,9 @@ public List<Hash256> retrieveRangeFromDatabase(final Hash256 startHash, final Bl
 
         BigInteger blocksInRange = endHeader.getBlockNumber()
                 .subtract(startHeader.getBlockNumber()).add(BigInteger.ONE);
-        List<Hash256> hashes = new ArrayList<>(blocksInRange.intValue());
+        List<Hash256> hashes = new ArrayList<>(blocksInRange.intValueExact());
 
-        int lastPosition = blocksInRange.intValue() - 1;
+        int lastPosition = blocksInRange.intValueExact() - 1;
 
         hashes.add(0, startHash);
         hashes.add(lastPosition, endHeader.getHash());

diff --git a/src/main/java/com/limechain/sync/fullsync/FullSyncMachine.java b/src/main/java/com/limechain/sync/fullsync/FullSyncMachine.java
@@ -115,7 +115,7 @@ public void start() {
 
         int startNumber = syncState.getLastFinalizedBlockNumber()
                 .add(BigInteger.ONE)
-                .intValue();
+                .intValueExact();
 
         int blocksToFetch = 100;
         List<Block> receivedBlocks = requester.requestBlocks(BlockRequestField.ALL, startNumber, blocksToFetch).join();

diff --git a/src/main/java/com/limechain/sync/warpsync/WarpSyncState.java b/src/main/java/com/limechain/sync/warpsync/WarpSyncState.java
@@ -273,7 +273,7 @@ private void updateSetData(BigInteger setChangeBlock) {
 
         List<BlockData> response = requester.requestBlockData(
                 BlockRequestField.ALL,
-                setChangeBlock.intValue(),
+                setChangeBlock.intValueExact(),
                 1
         ).join();
 

diff --git a/src/main/java/com/limechain/transaction/TransactionProcessor.java b/src/main/java/com/limechain/transaction/TransactionProcessor.java
@@ -180,7 +180,7 @@ private static TransactionValidationRequest createScaleValidationRequest(BigInte
                                                                              Extrinsic transaction) {
         TransactionValidationRequest request = new TransactionValidationRequest();
 
-        switch (txQueueVersion.intValue()) {
+        switch (txQueueVersion.intValueExact()) {
             case 1 -> request.setTransaction(transaction.getData());
             case 2 -> {
                 request.setSource(source);

diff --git a/src/test/java/com/limechain/sync/fullsync/InMemoryDB.java b/src/test/java/com/limechain/sync/fullsync/InMemoryDB.java
@@ -49,15 +49,15 @@ public List<byte[]> findKeysByPrefix(String prefixSeek, int limit) {
 
     @Override
     public DeleteByPrefixResult deleteByPrefix(String prefix, Long limit) {
-        var keys = this.findKeysByPrefix(prefix, limit.intValue());
+        var keys = this.findKeysByPrefix(prefix, Math.toIntExact(limit));
 
         int deleted = 0;
         for (var key : keys) {
             storage.remove(new String(key));
             deleted++;
         }
 
-        boolean allDeleted = this.findKeysByPrefix(prefix, limit.intValue()).isEmpty();
+        boolean allDeleted = this.findKeysByPrefix(prefix, Math.toIntExact(limit)).isEmpty();
 
         return new DeleteByPrefixResult(deleted, allDeleted);
     }