Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: deploy docs via GCP #8

Merged
merged 3 commits into from
Mar 21, 2024
Merged

ci: deploy docs via GCP #8

merged 3 commits into from
Mar 21, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 18, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

replace GH pages with our hosted docs

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from lantiga as a code owner March 18, 2024 19:38
@github-actions github-actions bot added the ci label Mar 18, 2024
@Borda Borda force-pushed the docs/deploy branch 2 times, most recently from 28d8951 to 1059900 Compare March 18, 2024 19:50
@Borda Borda changed the base branch from legacy to main March 20, 2024 22:18
@Borda Borda requested a review from t-vi as a code owner March 20, 2024 22:18
t-vi
t-vi approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Borda

@Borda Borda merged commit 0a1c6c4 into main Mar 21, 2024
32 checks passed
@Borda Borda deleted the docs/deploy branch March 21, 2024 17:39
@kshitij12345 kshitij12345 mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @t-vi