Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import updates of utils, baseutils, and codeutils. #1444

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Import updates of utils, baseutils, and codeutils. #1444

wants to merge 3 commits into from

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Nov 14, 2024

What does this PR do?

Add __all__ to baseutils and codeutils then update imports of utils

@crcrpar
dunder all and some import fix
d879f3d 
Signed-off-by: Masaki Kozuki <[email protected]>
@mruberry
Copy link
Collaborator

Test failures look related

@crcrpar
add default_dataclass_params
045f2b7 
Signed-off-by: Masaki Kozuki <[email protected]>
@crcrpar
no Optional
37affd7 
Signed-off-by: Masaki Kozuki <[email protected]>
@crcrpar crcrpar enabled auto-merge (squash) November 16, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crcrpar @mruberry