Merge pull request #39 from LibreSign/bugfix/check-if-key-exists

Check if key exists
LibreSign · Jun 8, 2023 · 844f912 · 844f912
2 parents 83f9fbe + 324ef77
commit 844f912
Show file tree

Hide file tree

Showing 6 changed files with 56 additions and 33 deletions.
diff --git a/composer.json b/composer.json
@@ -45,7 +45,14 @@
     "config": {
         "allow-plugins": {
             "bamarni/composer-bin-plugin": true
-        }
+        },
+        "optimize-autoloader": true
+    },
+    "extra": {
+      "bamarni-bin": {
+        "bin-links": true,
+        "forward-command": true
+      }
     },
     "autoload": {
         "psr-4": {

diff --git a/psalm.xml b/psalm.xml
@@ -1,6 +1,8 @@
 <?xml version="1.0"?>
 <psalm
     errorLevel="2"
+    findUnusedBaselineEntry="true"
+    findUnusedCode="false"
     resolveFromConfigFile="true"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"

diff --git a/src/NextcloudApiContext.php b/src/NextcloudApiContext.php
@@ -245,6 +245,11 @@ public function theResponseShouldBeAJsonArrayWithTheFollowingMandatoryValues(Tab
 		$expectedValues = $table->getColumnsHash();
 		$realResponseArray = json_decode($this->response->getBody()->getContents(), true);
 		foreach ($expectedValues as $value) {
+			Assert::assertArrayHasKey(
+				$value['key'],
+				$realResponseArray,
+				'Not found: "' . $value['key'] . '" at array: ' . json_encode($realResponseArray)
+			);
 			if (is_bool($realResponseArray[$value['key']])
 				|| is_iterable($realResponseArray[$value['key']])
 				|| is_numeric($realResponseArray[$value['key']])

diff --git a/vendor-bin/coding-standard/composer.json b/vendor-bin/coding-standard/composer.json
@@ -1,5 +1,5 @@
 {
     "require-dev": {
-        "nextcloud/coding-standard": "^1.1"
+        "nextcloud/coding-standard": "1.1.0"
     }
 }
diff --git a/vendor-bin/coding-standard/composer.lock b/vendor-bin/coding-standard/composer.lock
diff --git a/vendor-bin/psalm/composer.lock b/vendor-bin/psalm/composer.lock