Work around deadlock when calling xbmc.executebuildin(Reboot)

[mglae]

Calling xbmc.executebuildin('Reboot') from Settings addon result in deadlock in libdbus python callback.

Use /usr/bin/systemctl --no-block reboot instead.

Backtrace: http://ix.io/2KYC Debug log: http://ix.io/2KYD

For the tests a minimal not functional version of the bluetooth.py module was used to avoid the typical hang on exit because of using dbus-python (deleting bluetooth.py is possible too).

Note: calling xbmc.executebuildin('Reboot') from an addon not using dbus i.e. script.hello.world.reboot-matrix.zip is still possible.

[thoradia]

Why not calliing /usr/bin/systemctl --no-block reboot
Do however avoid referring to the oe.execute in particular or to the oe package in general, which will gradually be made obsolete
Instead use subprocess.check_output(command.split())

[mglae]

Why not calliing /usr/bin/systemctl --no-block reboot

That is exactly called. Or do I miss something?

Do however avoid referring to the oe.execute in particular or to the oe package in general, which will gradually be made obsolete

oe.execute() is the currently used function all over the code. If this is replaced in the future all appearances can be replaced by the then preferred call.

[flubshi]

My Raspberry PI 4 usually won't restart using the LE Settings Addons manual update mechanism. I tested this PR as described here, using service.libreelec.settings_wo_bluetooth-9.80-20210105.zip.

This PR seems to fix the issue for me. All 4 of 4 update attempts with this LE Settings version worked flawless and the pi booted after image was downloaded.

Thanks @mglae !

[khaoohs]

My Raspberry PI 4 usually won't restart using the LE Settings Addons manual update mechanism. I tested this PR as described here, using service.libreelec.settings_wo_bluetooth-9.80-20210105.zip.

This PR seems to fix the issue for me. All 4 of 4 update attempts with this LE Settings version worked flawless and the pi booted after image was downloaded.

Thanks @mglae !

Same for me with Intel x86.

[chewitt]

@mglae is it possible to do this without the oe.execute dependency? then we're not adding to the work of removing it.

[mglae]

Done.

[flubshi]

I tested the new version using subprocess.call instead of oe.execute from le10_no_executebuildin_reboo branch. This works reliable as well.
@chewitt is this going to be accepted?

[mglae]

To partial repeat comment 1: this is not sufficient to fix the hang on reboot. It still occur when using dbus-python in bluetooth.py.