Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validate #333

Merged
merged 2 commits into from
Feb 8, 2018
Merged

Feature/validate #333

merged 2 commits into from
Feb 8, 2018

Conversation

nics
Copy link
Member

@nics nics commented Feb 2, 2018

Hi @nichtich I repackaged your validation code as a pull request.
I thinks this needs a little bit of cleanup and we want to release the current dev branch first to fix some filestore/multithreading related bugs.

@nics nics assigned nichtich and nics Feb 2, 2018
@coveralls
Copy link

coveralls commented Feb 2, 2018

Coverage Status

Coverage increased (+0.02%) to 94.499% when pulling ab0a068 on feature/validate into b7292bc on dev.

@nics nics merged commit ab0a068 into dev Feb 8, 2018
@nics
Copy link
Member Author

nics commented Feb 8, 2018

hi @nichtich I removed the verbose option and made an issue to enhance the log fix (and others) to take the value of a field. That provides a more general solution:

   validate('author', MyValidatorClass, error_field: warnings)
   log($.warnings)

@nics
Copy link
Member Author

nics commented Feb 8, 2018

Just realized there's already a long lingering issue #211 that proposes something similar.

@nics nics deleted the feature/validate branch February 8, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants