Make is_on optional #79
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is_on function is unavailable on some remotes/controllers, which causes Pydantic to crash the app.
Leggin
requested changes
Jul 16, 2024
| @@ -5,7 +5,7 @@ | |||
|
|
|||
|
|
|||
| class ControllerAttributes(Attributes): | |||
| is_on: bool | |||
| is_on: bool = None | |||
There was a problem hiding this comment.
please use the same syntax as with other optionals here:
Optional[bool] = None
|
solved in #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is_on bool is unavailable on some remotes/controllers, which causes Pydantic to crash the app. This change makes is_on optional.
Tested on STYRBAR E2002 and SYMFONISK sound remote gen2 E2123.