Added Starkvind device control #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added starkvind device and tests
added air purifier into readme
added missing return value and final new line
|
Thank you looks really good! |
remove whitespace in test_air_purifier.py
remove whitespaces in air_purifier.py
|
All done! Hopefully the CI doesn't complain anymore :D |
|
awesome! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to control Starkvind air purifiers with Dirigera hub.
air_purifier.py was tested with my own two purifiers to check functionality.
class was written based on coding style in other classes.
test_air_purifier.py created and passing.
readme.md also updated.
i don't think any more tasks are open