Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-api): only bypass derivation check on LL for ACRE flows [LIVE-15787] #8935

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Jan 17, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests. Not sure if we can test this with speculos
  • Impact of the changes:
    • wallet-api ACRE flows

πŸ“ Description

Added back the account for the connect action even with an appName present as we should still keep it
And only bypass the derivation check on LL for ACRE flows

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this Jan 17, 2025
@Justkant Justkant requested review from a team as code owners January 17, 2025 08:32
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 17, 2025 8:32am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jan 17, 2025 8:32am
native-ui-storybook ⬜️ Ignored (Inspect) Jan 17, 2025 8:32am
react-ui-storybook ⬜️ Ignored (Inspect) Jan 17, 2025 8:32am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant