Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Misleading Casper Token #8934

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Canestin
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Currently, in the code /ledger-live/libs/ledgerjs/packages/cryptoassets/src/data/casper.ts, this hardcoded file gives the impression that Casper tokens can be added. However, it seems this was a copy-paste operation. To avoid confusion, we are removing it. If we ever need to support this, we will do it properly with CAL Importers compatibility.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested a review from a team as a code owner January 17, 2025 05:32
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Jan 17, 2025 3:08pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 3:08pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 3:08pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 3:08pm

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Jan 17, 2025
Copy link
Member

@hedi-edelbloute hedi-edelbloute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove stuff in libs/ledgerjs/packages/cryptoassets/src/tokens.ts also ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants