Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create banner to warn users about potential issues #8933

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Canestin
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

we should create generic translated banner with differents parameters. We will use first use this banner to warn our users about ADA staking issue :

Text : The following feature is momentarily unavailable : {{feature}}, to know more please refer to support.

image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested review from a team as code owners January 17, 2025 05:12
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:15am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:15am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:15am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:15am

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Jan 17, 2025
@Canestin Canestin force-pushed the LIVE-15643-warning-generic-banner branch from 521115e to 16419b3 Compare January 17, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant