Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add cargo ledger #103

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Feat/add cargo ledger #103

merged 6 commits into from
Dec 11, 2023

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Dec 8, 2023

No description provided.

@yogh333 yogh333 marked this pull request as ready for review December 8, 2023 12:09
@@ -0,0 +1,18 @@
[package]
name = "cargo-ledger"
version = "1.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the version ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should update the version in the app-builder docker images

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I will bump the version to 1.2.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the version in the app builder image in LedgerHQ/ledger-app-builder#91

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have other changes in https://github.com/LedgerHQ/cargo-ledger/pull/35/files that I would like to add once we merge this PR

@yogh333 yogh333 merged commit 2cc6c8e into master Dec 11, 2023
21 checks passed
@yogh333 yogh333 deleted the feat/add_cargo_ledger branch December 11, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants