-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to run Guideline_Enforcer #147
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
7a0edfb
to
faeb44c
Compare
faeb44c
to
9e273e7
Compare
@cedelavergne-ledger shouldn't the It seems to me the script is tightly linked to the workflows |
No, because for the VSCode extension, we need a simple and straight forward method, ideally based on a script: The final usage, with the extension, will be to open the |
9e273e7
to
ed6294d
Compare
@@ -19,5 +19,11 @@ ARG PYTHON_BUILD_DEPS=libffi-dev,python3-dev,py3-virtualenv | |||
# Install the building dependencies. | |||
RUN apk add $(echo -n "$PYTHON_BUILD_DEPS" | tr , ' ') | |||
|
|||
# Install packahes to allow Guideline Enforcer to run | |||
RUN apk add imagemagick grep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details
Details
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes
Expected: RUN instruction with 'apk add ' should use package pinning form 'apk add =' Found: RUN instruction apk add imagemagick grep does not use package pinning form
RUN pip3 install --no-cache-dir "ragger[tests,all_backends]==1.24.0" "speculos==0.10.0" | ||
|
||
# Add the enforcer script | ||
ADD ./dev-tools/enforcer.sh /opt/enforcer.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details
Details
Should use COPY instead of ADD unless, running a tar file
Expected: 'COPY' ./dev-tools/enforcer.sh Found: 'ADD' ./dev-tools/enforcer.sh
@@ -19,5 +19,11 @@ ARG PYTHON_BUILD_DEPS=libffi-dev,python3-dev,py3-virtualenv | |||
# Install the building dependencies. | |||
RUN apk add $(echo -n "$PYTHON_BUILD_DEPS" | tr , ' ') | |||
|
|||
# Install packahes to allow Guideline Enforcer to run | |||
RUN apk add imagemagick grep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details
Details
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes
Expected: RUN instruction with 'apk add ' should use package pinning form 'apk add =' Found: RUN instruction apk add imagemagick grep does not use package pinning form
RUN pip3 install --no-cache-dir "ragger[tests,all_backends]==1.24.0" "speculos==0.10.0" | ||
|
||
# Add the enforcer script | ||
ADD ./dev-tools/enforcer.sh /opt/enforcer.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details
Details
Should use COPY instead of ADD unless, running a tar file
Expected: 'COPY' ./dev-tools/enforcer.sh Found: 'ADD' ./dev-tools/enforcer.sh
Add script allowing to call the Guideline Enforcer checks from
ledger-app-workflows
repository.Add missing packages in the container
Bump Speculos & Ragger to their latest version