Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lcov #120

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix lcov #120

merged 2 commits into from
May 15, 2024

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented May 15, 2024 •
edited
Loading

@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented May 15, 2024 •
edited
Loading

Wiz Scan Summary
IaC Misconfigurations 0C 0H 1M 0L 1I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 1M 0L 1I
Secrets 0🔑

lpascal-ledger
lpascal-ledger approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@lpascal-ledger lpascal-ledger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work 👍

Could you just bump a 3.22.1 version? It won't be released immediately but the CI will be able to run.

@lpascal-ledger lpascal-ledger merged commit 79bf6a1 into master May 15, 2024
10 checks passed
@lpascal-ledger lpascal-ledger deleted the fix/apa/lcov branch May 15, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

@lpascal-ledger lpascal-ledger lpascal-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#118 breaks unit-test/codecov workflows.
3 participants
@apaillier-ledger @lpascal-ledger @fbeutin-ledger