Fix blind-signing regression #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would refuse the APDU but then start a empty signature flow on the device Which would crash the device when accepted or rejected
apaillier-ledger
force-pushed
the
fix/apa/blind_signing_regression
branch
from
3d8e62f to
72f8bad
Compare
apaillier-ledger
force-pushed
the
fix/apa/blind_signing_regression
branch
from
72f8bad to
30067d6
Compare
tdejoigny-ledger
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Would refuse the APDU but then start a empty signature flow on the device, which would crash the device when accepted or rejected.
Introduced in c353982
Also added new signature + verification tests for both legacy & 1559 transactions made possible by #543
Changes include